Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to read subtitle #130

Open
EllaHa opened this issue Oct 15, 2018 · 2 comments
Open

Impossible to read subtitle #130

EllaHa opened this issue Oct 15, 2018 · 2 comments

Comments

@EllaHa
Copy link

EllaHa commented Oct 15, 2018

Impossible to select subtitles even if subtitles have been uploaded on the editor.
image

Codecast link

https://codecast.france-ioi.org/v6/player?stepperControls=_undo,_redo,_expr,_out,_over&base=https%3A%2F%2Ffioi-recordings.s3.amazonaws.com%2Fdartmouth%2F1518204459525

[Related to(https://github.com/remisharrock/c-programming-with-linux-MOOC-issues-tracker/issues/194)

image

@epixode
Copy link

epixode commented Oct 15, 2018

The subtitles file does not load because item 40 contains invalid characters *** at the end of the line:

00:01:20,100 --> 00:01:22,700***

Removing these characters in the editor should allow the subtitles to load.
Marking as enhancement:

  • error reporting in the player can be improved
  • early error detection in the editor would be helpful

The 404 status code in the screenshot is not normal, perhaps a cache header configuration issue.

@EllaHa
Copy link
Author

EllaHa commented Oct 15, 2018

Thanks Sebastian for noticing this. this is now working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants