Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: provide support for importing BIP-38 encrypted private keys (paper wallets) #74

Open
robster7674 opened this issue Dec 18, 2021 · 2 comments

Comments

@robster7674
Copy link

Dear Team, please support importing private keys. It's unfortunate to see many of the modern wallets only support importing seed phrases, but do not provide support for one of the things most fundamental to ₿Itcoin: paper wallets/private keys. Please set an example and implement support for this. That would make your product even better than it already is.

@jonathancross
Copy link

Am I correct that you are specifically asking for both BIP-38 & QR code scanning support?

NOTE: BIP-38 wallets should be considered deprecated as there is very little support for these. Please consider migrating to a modern standard with wider support. If this is implemented, I'd suggest it be done as a "sweep" option, in which the encrypted keys are imported via QR code, then decrypted with the user's passphrase, then funds are sent immediately to another (modern) wallet. Passport should not attempt to store keys, manage change, or keep any state for the BIP-38 wallet IMHO.

@misterdna
Copy link

misterdna commented Sep 16, 2023

I wanted to revisit this feature request, though I think a sweep feature is what is really needed. I believe there still isn't a single HW wallet that can sweep a private key. Anyone who has bitcoin on a paper wallet and doesn't feel extremely technical is faced with daunting technical hurdles to transfer funds off the wallet with some semblance of security, or else just throw caution to the wind and hope things work out okay using a low-security wallet on an online device (even if it's just as an intermediary to an offline device). I'd argue developing and marketing a sweep feature within an offline device would drive sales from a lot of OGs and others sitting on high-value paper wallets. It would be a really cool differentiating feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants