From a320b3e9da07e8f9bcecaf6024b6d847c8f12872 Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 20:03:34 +0200 Subject: [PATCH 01/10] SFT-3538: Remove .git suffix from GitHub URLs. It causes redirections. * ffi/integration/CMakeLists.txt (Corrosion): Remove .git suffix. (googletest): Remove .git suffix. --- ffi/integration/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ffi/integration/CMakeLists.txt b/ffi/integration/CMakeLists.txt index 5838841..4f11fd4 100644 --- a/ffi/integration/CMakeLists.txt +++ b/ffi/integration/CMakeLists.txt @@ -10,12 +10,12 @@ set(CMAKE_CXX_STANDARD 14) FetchContent_Declare( Corrosion - GIT_REPOSITORY https://github.com/corrosion-rs/corrosion.git GIT_TAG v0.3.5 + GIT_REPOSITORY https://github.com/corrosion-rs/corrosion ) FetchContent_Declare( googletest - GIT_REPOSITORY https://github.com/google/googletest.git + GIT_REPOSITORY https://github.com/google/googletest GIT_TAG v1.13.0 ) From 77363ef64e153a4c969b181d54ed28b374217d06 Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 20:04:28 +0200 Subject: [PATCH 02/10] SFT-3538: Update corrosion to 0.4.9. * ffi/integration/CMakeLists.txt (Corrosion): Update to 0.4.9. --- ffi/integration/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffi/integration/CMakeLists.txt b/ffi/integration/CMakeLists.txt index 4f11fd4..02580d2 100644 --- a/ffi/integration/CMakeLists.txt +++ b/ffi/integration/CMakeLists.txt @@ -10,8 +10,8 @@ set(CMAKE_CXX_STANDARD 14) FetchContent_Declare( Corrosion - GIT_TAG v0.3.5 GIT_REPOSITORY https://github.com/corrosion-rs/corrosion + GIT_TAG v0.4.9 ) FetchContent_Declare( googletest From 61930b27c078de354e73077f64b901b3cbb612d5 Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Mon, 15 Apr 2024 18:52:08 +0200 Subject: [PATCH 03/10] SFT-3538: Replace vim by xxd package. * manifest.scm: Replace vim by xxd package. --- manifest.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifest.scm b/manifest.scm index d15b3d1..36f6f81 100644 --- a/manifest.scm +++ b/manifest.scm @@ -18,4 +18,4 @@ ;; Nice to have utilities. "hal" - "vim")) ;; For xxd command. + "xxd")) From 086955a615d0daf13f31bc120b54434423944e32 Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 20:05:54 +0200 Subject: [PATCH 04/10] SFT-3538: Add nlhomann-json to manifest. * manifest.scm: Add nlhomann-json. --- manifest.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/manifest.scm b/manifest.scm index 36f6f81..d184990 100644 --- a/manifest.scm +++ b/manifest.scm @@ -11,6 +11,7 @@ "guile" "jq" "make" + "nlohmann-json" "reuse" "rust" "rust:cargo" From 36dd91d4243b884e3f75d1dbe0681cf7e194743a Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Mon, 8 Apr 2024 16:46:02 +0200 Subject: [PATCH 05/10] SFT-3538: Update bitcoin_hashes to 0.14. * Cargo.toml (workspace.dependencies) : Update to 0.14. --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 57f32d3..c39f2f5 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -21,7 +21,7 @@ arbitrary = { version = "1", features = ["derive"] } bech32 = { version = "0.9", default-features = false } bip39 = { version = "2", default-features = false } bitcoin = { version = "0.31", default-features = false } -bitcoin_hashes = { version = "0.13", default-features = false } +bitcoin_hashes = { version = "0.14", default-features = false } bs58 = "0.5" crc = "3" criterion = { version = "0.4" } From 0b2af224dc71a294bb33081cb7ca0ea50a09581f Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 19:53:31 +0200 Subject: [PATCH 06/10] SFT-3538: Add GPL-3.0-only license. * LICENSES/GPL-3.0-only.txt: New license. --- LICENSES/GPL-3.0-only.txt | 232 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 232 insertions(+) create mode 100644 LICENSES/GPL-3.0-only.txt diff --git a/LICENSES/GPL-3.0-only.txt b/LICENSES/GPL-3.0-only.txt new file mode 100644 index 0000000..f6cdd22 --- /dev/null +++ b/LICENSES/GPL-3.0-only.txt @@ -0,0 +1,232 @@ +GNU GENERAL PUBLIC LICENSE +Version 3, 29 June 2007 + +Copyright © 2007 Free Software Foundation, Inc. + +Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. + +Preamble + +The GNU General Public License is a free, copyleft license for software and other kinds of works. + +The licenses for most software and other practical works are designed to take away your freedom to share and change the works. By contrast, the GNU General Public License is intended to guarantee your freedom to share and change all versions of a program--to make sure it remains free software for all its users. We, the Free Software Foundation, use the GNU General Public License for most of our software; it applies also to any other work released this way by its authors. You can apply it to your programs, too. + +When we speak of free software, we are referring to freedom, not price. Our General Public Licenses are designed to make sure that you have the freedom to distribute copies of free software (and charge for them if you wish), that you receive source code or can get it if you want it, that you can change the software or use pieces of it in new free programs, and that you know you can do these things. + +To protect your rights, we need to prevent others from denying you these rights or asking you to surrender the rights. Therefore, you have certain responsibilities if you distribute copies of the software, or if you modify it: responsibilities to respect the freedom of others. + +For example, if you distribute copies of such a program, whether gratis or for a fee, you must pass on to the recipients the same freedoms that you received. You must make sure that they, too, receive or can get the source code. And you must show them these terms so they know their rights. + +Developers that use the GNU GPL protect your rights with two steps: (1) assert copyright on the software, and (2) offer you this License giving you legal permission to copy, distribute and/or modify it. + +For the developers' and authors' protection, the GPL clearly explains that there is no warranty for this free software. For both users' and authors' sake, the GPL requires that modified versions be marked as changed, so that their problems will not be attributed erroneously to authors of previous versions. + +Some devices are designed to deny users access to install or run modified versions of the software inside them, although the manufacturer can do so. This is fundamentally incompatible with the aim of protecting users' freedom to change the software. The systematic pattern of such abuse occurs in the area of products for individuals to use, which is precisely where it is most unacceptable. Therefore, we have designed this version of the GPL to prohibit the practice for those products. If such problems arise substantially in other domains, we stand ready to extend this provision to those domains in future versions of the GPL, as needed to protect the freedom of users. + +Finally, every program is threatened constantly by software patents. States should not allow patents to restrict development and use of software on general-purpose computers, but in those that do, we wish to avoid the special danger that patents applied to a free program could make it effectively proprietary. To prevent this, the GPL assures that patents cannot be used to render the program non-free. + +The precise terms and conditions for copying, distribution and modification follow. + +TERMS AND CONDITIONS + +0. Definitions. + +“This License” refers to version 3 of the GNU General Public License. + +“Copyright” also means copyright-like laws that apply to other kinds of works, such as semiconductor masks. + +“The Program” refers to any copyrightable work licensed under this License. Each licensee is addressed as “you”. “Licensees” and “recipients” may be individuals or organizations. + +To “modify” a work means to copy from or adapt all or part of the work in a fashion requiring copyright permission, other than the making of an exact copy. The resulting work is called a “modified version” of the earlier work or a work “based on” the earlier work. + +A “covered work” means either the unmodified Program or a work based on the Program. + +To “propagate” a work means to do anything with it that, without permission, would make you directly or secondarily liable for infringement under applicable copyright law, except executing it on a computer or modifying a private copy. Propagation includes copying, distribution (with or without modification), making available to the public, and in some countries other activities as well. + +To “convey” a work means any kind of propagation that enables other parties to make or receive copies. Mere interaction with a user through a computer network, with no transfer of a copy, is not conveying. + +An interactive user interface displays “Appropriate Legal Notices” to the extent that it includes a convenient and prominently visible feature that (1) displays an appropriate copyright notice, and (2) tells the user that there is no warranty for the work (except to the extent that warranties are provided), that licensees may convey the work under this License, and how to view a copy of this License. If the interface presents a list of user commands or options, such as a menu, a prominent item in the list meets this criterion. + +1. Source Code. +The “source code” for a work means the preferred form of the work for making modifications to it. “Object code” means any non-source form of a work. + +A “Standard Interface” means an interface that either is an official standard defined by a recognized standards body, or, in the case of interfaces specified for a particular programming language, one that is widely used among developers working in that language. + +The “System Libraries” of an executable work include anything, other than the work as a whole, that (a) is included in the normal form of packaging a Major Component, but which is not part of that Major Component, and (b) serves only to enable use of the work with that Major Component, or to implement a Standard Interface for which an implementation is available to the public in source code form. A “Major Component”, in this context, means a major essential component (kernel, window system, and so on) of the specific operating system (if any) on which the executable work runs, or a compiler used to produce the work, or an object code interpreter used to run it. + +The “Corresponding Source” for a work in object code form means all the source code needed to generate, install, and (for an executable work) run the object code and to modify the work, including scripts to control those activities. However, it does not include the work's System Libraries, or general-purpose tools or generally available free programs which are used unmodified in performing those activities but which are not part of the work. For example, Corresponding Source includes interface definition files associated with source files for the work, and the source code for shared libraries and dynamically linked subprograms that the work is specifically designed to require, such as by intimate data communication or control flow between those subprograms and other parts of the work. + +The Corresponding Source need not include anything that users can regenerate automatically from other parts of the Corresponding Source. + +The Corresponding Source for a work in source code form is that same work. + +2. Basic Permissions. +All rights granted under this License are granted for the term of copyright on the Program, and are irrevocable provided the stated conditions are met. This License explicitly affirms your unlimited permission to run the unmodified Program. The output from running a covered work is covered by this License only if the output, given its content, constitutes a covered work. This License acknowledges your rights of fair use or other equivalent, as provided by copyright law. + +You may make, run and propagate covered works that you do not convey, without conditions so long as your license otherwise remains in force. You may convey covered works to others for the sole purpose of having them make modifications exclusively for you, or provide you with facilities for running those works, provided that you comply with the terms of this License in conveying all material for which you do not control copyright. Those thus making or running the covered works for you must do so exclusively on your behalf, under your direction and control, on terms that prohibit them from making any copies of your copyrighted material outside their relationship with you. + +Conveying under any other circumstances is permitted solely under the conditions stated below. Sublicensing is not allowed; section 10 makes it unnecessary. + +3. Protecting Users' Legal Rights From Anti-Circumvention Law. +No covered work shall be deemed part of an effective technological measure under any applicable law fulfilling obligations under article 11 of the WIPO copyright treaty adopted on 20 December 1996, or similar laws prohibiting or restricting circumvention of such measures. + +When you convey a covered work, you waive any legal power to forbid circumvention of technological measures to the extent such circumvention is effected by exercising rights under this License with respect to the covered work, and you disclaim any intention to limit operation or modification of the work as a means of enforcing, against the work's users, your or third parties' legal rights to forbid circumvention of technological measures. + +4. Conveying Verbatim Copies. +You may convey verbatim copies of the Program's source code as you receive it, in any medium, provided that you conspicuously and appropriately publish on each copy an appropriate copyright notice; keep intact all notices stating that this License and any non-permissive terms added in accord with section 7 apply to the code; keep intact all notices of the absence of any warranty; and give all recipients a copy of this License along with the Program. + +You may charge any price or no price for each copy that you convey, and you may offer support or warranty protection for a fee. + +5. Conveying Modified Source Versions. +You may convey a work based on the Program, or the modifications to produce it from the Program, in the form of source code under the terms of section 4, provided that you also meet all of these conditions: + + a) The work must carry prominent notices stating that you modified it, and giving a relevant date. + + b) The work must carry prominent notices stating that it is released under this License and any conditions added under section 7. This requirement modifies the requirement in section 4 to “keep intact all notices”. + + c) You must license the entire work, as a whole, under this License to anyone who comes into possession of a copy. This License will therefore apply, along with any applicable section 7 additional terms, to the whole of the work, and all its parts, regardless of how they are packaged. This License gives no permission to license the work in any other way, but it does not invalidate such permission if you have separately received it. + + d) If the work has interactive user interfaces, each must display Appropriate Legal Notices; however, if the Program has interactive interfaces that do not display Appropriate Legal Notices, your work need not make them do so. + +A compilation of a covered work with other separate and independent works, which are not by their nature extensions of the covered work, and which are not combined with it such as to form a larger program, in or on a volume of a storage or distribution medium, is called an “aggregate” if the compilation and its resulting copyright are not used to limit the access or legal rights of the compilation's users beyond what the individual works permit. Inclusion of a covered work in an aggregate does not cause this License to apply to the other parts of the aggregate. + +6. Conveying Non-Source Forms. +You may convey a covered work in object code form under the terms of sections 4 and 5, provided that you also convey the machine-readable Corresponding Source under the terms of this License, in one of these ways: + + a) Convey the object code in, or embodied in, a physical product (including a physical distribution medium), accompanied by the Corresponding Source fixed on a durable physical medium customarily used for software interchange. + + b) Convey the object code in, or embodied in, a physical product (including a physical distribution medium), accompanied by a written offer, valid for at least three years and valid for as long as you offer spare parts or customer support for that product model, to give anyone who possesses the object code either (1) a copy of the Corresponding Source for all the software in the product that is covered by this License, on a durable physical medium customarily used for software interchange, for a price no more than your reasonable cost of physically performing this conveying of source, or (2) access to copy the Corresponding Source from a network server at no charge. + + c) Convey individual copies of the object code with a copy of the written offer to provide the Corresponding Source. This alternative is allowed only occasionally and noncommercially, and only if you received the object code with such an offer, in accord with subsection 6b. + + d) Convey the object code by offering access from a designated place (gratis or for a charge), and offer equivalent access to the Corresponding Source in the same way through the same place at no further charge. You need not require recipients to copy the Corresponding Source along with the object code. If the place to copy the object code is a network server, the Corresponding Source may be on a different server (operated by you or a third party) that supports equivalent copying facilities, provided you maintain clear directions next to the object code saying where to find the Corresponding Source. Regardless of what server hosts the Corresponding Source, you remain obligated to ensure that it is available for as long as needed to satisfy these requirements. + + e) Convey the object code using peer-to-peer transmission, provided you inform other peers where the object code and Corresponding Source of the work are being offered to the general public at no charge under subsection 6d. + +A separable portion of the object code, whose source code is excluded from the Corresponding Source as a System Library, need not be included in conveying the object code work. + +A “User Product” is either (1) a “consumer product”, which means any tangible personal property which is normally used for personal, family, or household purposes, or (2) anything designed or sold for incorporation into a dwelling. In determining whether a product is a consumer product, doubtful cases shall be resolved in favor of coverage. For a particular product received by a particular user, “normally used” refers to a typical or common use of that class of product, regardless of the status of the particular user or of the way in which the particular user actually uses, or expects or is expected to use, the product. A product is a consumer product regardless of whether the product has substantial commercial, industrial or non-consumer uses, unless such uses represent the only significant mode of use of the product. + +“Installation Information” for a User Product means any methods, procedures, authorization keys, or other information required to install and execute modified versions of a covered work in that User Product from a modified version of its Corresponding Source. The information must suffice to ensure that the continued functioning of the modified object code is in no case prevented or interfered with solely because modification has been made. + +If you convey an object code work under this section in, or with, or specifically for use in, a User Product, and the conveying occurs as part of a transaction in which the right of possession and use of the User Product is transferred to the recipient in perpetuity or for a fixed term (regardless of how the transaction is characterized), the Corresponding Source conveyed under this section must be accompanied by the Installation Information. But this requirement does not apply if neither you nor any third party retains the ability to install modified object code on the User Product (for example, the work has been installed in ROM). + +The requirement to provide Installation Information does not include a requirement to continue to provide support service, warranty, or updates for a work that has been modified or installed by the recipient, or for the User Product in which it has been modified or installed. Access to a network may be denied when the modification itself materially and adversely affects the operation of the network or violates the rules and protocols for communication across the network. + +Corresponding Source conveyed, and Installation Information provided, in accord with this section must be in a format that is publicly documented (and with an implementation available to the public in source code form), and must require no special password or key for unpacking, reading or copying. + +7. Additional Terms. +“Additional permissions” are terms that supplement the terms of this License by making exceptions from one or more of its conditions. Additional permissions that are applicable to the entire Program shall be treated as though they were included in this License, to the extent that they are valid under applicable law. If additional permissions apply only to part of the Program, that part may be used separately under those permissions, but the entire Program remains governed by this License without regard to the additional permissions. + +When you convey a copy of a covered work, you may at your option remove any additional permissions from that copy, or from any part of it. (Additional permissions may be written to require their own removal in certain cases when you modify the work.) You may place additional permissions on material, added by you to a covered work, for which you have or can give appropriate copyright permission. + +Notwithstanding any other provision of this License, for material you add to a covered work, you may (if authorized by the copyright holders of that material) supplement the terms of this License with terms: + + a) Disclaiming warranty or limiting liability differently from the terms of sections 15 and 16 of this License; or + + b) Requiring preservation of specified reasonable legal notices or author attributions in that material or in the Appropriate Legal Notices displayed by works containing it; or + + c) Prohibiting misrepresentation of the origin of that material, or requiring that modified versions of such material be marked in reasonable ways as different from the original version; or + + d) Limiting the use for publicity purposes of names of licensors or authors of the material; or + + e) Declining to grant rights under trademark law for use of some trade names, trademarks, or service marks; or + + f) Requiring indemnification of licensors and authors of that material by anyone who conveys the material (or modified versions of it) with contractual assumptions of liability to the recipient, for any liability that these contractual assumptions directly impose on those licensors and authors. + +All other non-permissive additional terms are considered “further restrictions” within the meaning of section 10. If the Program as you received it, or any part of it, contains a notice stating that it is governed by this License along with a term that is a further restriction, you may remove that term. If a license document contains a further restriction but permits relicensing or conveying under this License, you may add to a covered work material governed by the terms of that license document, provided that the further restriction does not survive such relicensing or conveying. + +If you add terms to a covered work in accord with this section, you must place, in the relevant source files, a statement of the additional terms that apply to those files, or a notice indicating where to find the applicable terms. + +Additional terms, permissive or non-permissive, may be stated in the form of a separately written license, or stated as exceptions; the above requirements apply either way. + +8. Termination. +You may not propagate or modify a covered work except as expressly provided under this License. Any attempt otherwise to propagate or modify it is void, and will automatically terminate your rights under this License (including any patent licenses granted under the third paragraph of section 11). + +However, if you cease all violation of this License, then your license from a particular copyright holder is reinstated (a) provisionally, unless and until the copyright holder explicitly and finally terminates your license, and (b) permanently, if the copyright holder fails to notify you of the violation by some reasonable means prior to 60 days after the cessation. + +Moreover, your license from a particular copyright holder is reinstated permanently if the copyright holder notifies you of the violation by some reasonable means, this is the first time you have received notice of violation of this License (for any work) from that copyright holder, and you cure the violation prior to 30 days after your receipt of the notice. + +Termination of your rights under this section does not terminate the licenses of parties who have received copies or rights from you under this License. If your rights have been terminated and not permanently reinstated, you do not qualify to receive new licenses for the same material under section 10. + +9. Acceptance Not Required for Having Copies. +You are not required to accept this License in order to receive or run a copy of the Program. Ancillary propagation of a covered work occurring solely as a consequence of using peer-to-peer transmission to receive a copy likewise does not require acceptance. However, nothing other than this License grants you permission to propagate or modify any covered work. These actions infringe copyright if you do not accept this License. Therefore, by modifying or propagating a covered work, you indicate your acceptance of this License to do so. + +10. Automatic Licensing of Downstream Recipients. +Each time you convey a covered work, the recipient automatically receives a license from the original licensors, to run, modify and propagate that work, subject to this License. You are not responsible for enforcing compliance by third parties with this License. + +An “entity transaction” is a transaction transferring control of an organization, or substantially all assets of one, or subdividing an organization, or merging organizations. If propagation of a covered work results from an entity transaction, each party to that transaction who receives a copy of the work also receives whatever licenses to the work the party's predecessor in interest had or could give under the previous paragraph, plus a right to possession of the Corresponding Source of the work from the predecessor in interest, if the predecessor has it or can get it with reasonable efforts. + +You may not impose any further restrictions on the exercise of the rights granted or affirmed under this License. For example, you may not impose a license fee, royalty, or other charge for exercise of rights granted under this License, and you may not initiate litigation (including a cross-claim or counterclaim in a lawsuit) alleging that any patent claim is infringed by making, using, selling, offering for sale, or importing the Program or any portion of it. + +11. Patents. +A “contributor” is a copyright holder who authorizes use under this License of the Program or a work on which the Program is based. The work thus licensed is called the contributor's “contributor version”. + +A contributor's “essential patent claims” are all patent claims owned or controlled by the contributor, whether already acquired or hereafter acquired, that would be infringed by some manner, permitted by this License, of making, using, or selling its contributor version, but do not include claims that would be infringed only as a consequence of further modification of the contributor version. For purposes of this definition, “control” includes the right to grant patent sublicenses in a manner consistent with the requirements of this License. + +Each contributor grants you a non-exclusive, worldwide, royalty-free patent license under the contributor's essential patent claims, to make, use, sell, offer for sale, import and otherwise run, modify and propagate the contents of its contributor version. + +In the following three paragraphs, a “patent license” is any express agreement or commitment, however denominated, not to enforce a patent (such as an express permission to practice a patent or covenant not to sue for patent infringement). To “grant” such a patent license to a party means to make such an agreement or commitment not to enforce a patent against the party. + +If you convey a covered work, knowingly relying on a patent license, and the Corresponding Source of the work is not available for anyone to copy, free of charge and under the terms of this License, through a publicly available network server or other readily accessible means, then you must either (1) cause the Corresponding Source to be so available, or (2) arrange to deprive yourself of the benefit of the patent license for this particular work, or (3) arrange, in a manner consistent with the requirements of this License, to extend the patent license to downstream recipients. “Knowingly relying” means you have actual knowledge that, but for the patent license, your conveying the covered work in a country, or your recipient's use of the covered work in a country, would infringe one or more identifiable patents in that country that you have reason to believe are valid. + +If, pursuant to or in connection with a single transaction or arrangement, you convey, or propagate by procuring conveyance of, a covered work, and grant a patent license to some of the parties receiving the covered work authorizing them to use, propagate, modify or convey a specific copy of the covered work, then the patent license you grant is automatically extended to all recipients of the covered work and works based on it. + +A patent license is “discriminatory” if it does not include within the scope of its coverage, prohibits the exercise of, or is conditioned on the non-exercise of one or more of the rights that are specifically granted under this License. You may not convey a covered work if you are a party to an arrangement with a third party that is in the business of distributing software, under which you make payment to the third party based on the extent of your activity of conveying the work, and under which the third party grants, to any of the parties who would receive the covered work from you, a discriminatory patent license (a) in connection with copies of the covered work conveyed by you (or copies made from those copies), or (b) primarily for and in connection with specific products or compilations that contain the covered work, unless you entered into that arrangement, or that patent license was granted, prior to 28 March 2007. + +Nothing in this License shall be construed as excluding or limiting any implied license or other defenses to infringement that may otherwise be available to you under applicable patent law. + +12. No Surrender of Others' Freedom. +If conditions are imposed on you (whether by court order, agreement or otherwise) that contradict the conditions of this License, they do not excuse you from the conditions of this License. If you cannot convey a covered work so as to satisfy simultaneously your obligations under this License and any other pertinent obligations, then as a consequence you may not convey it at all. For example, if you agree to terms that obligate you to collect a royalty for further conveying from those to whom you convey the Program, the only way you could satisfy both those terms and this License would be to refrain entirely from conveying the Program. + +13. Use with the GNU Affero General Public License. +Notwithstanding any other provision of this License, you have permission to link or combine any covered work with a work licensed under version 3 of the GNU Affero General Public License into a single combined work, and to convey the resulting work. The terms of this License will continue to apply to the part which is the covered work, but the special requirements of the GNU Affero General Public License, section 13, concerning interaction through a network will apply to the combination as such. + +14. Revised Versions of this License. +The Free Software Foundation may publish revised and/or new versions of the GNU General Public License from time to time. Such new versions will be similar in spirit to the present version, but may differ in detail to address new problems or concerns. + +Each version is given a distinguishing version number. If the Program specifies that a certain numbered version of the GNU General Public License “or any later version” applies to it, you have the option of following the terms and conditions either of that numbered version or of any later version published by the Free Software Foundation. If the Program does not specify a version number of the GNU General Public License, you may choose any version ever published by the Free Software Foundation. + +If the Program specifies that a proxy can decide which future versions of the GNU General Public License can be used, that proxy's public statement of acceptance of a version permanently authorizes you to choose that version for the Program. + +Later license versions may give you additional or different permissions. However, no additional obligations are imposed on any author or copyright holder as a result of your choosing to follow a later version. + +15. Disclaimer of Warranty. +THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM “AS IS” WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, REPAIR OR CORRECTION. + +16. Limitation of Liability. +IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF SUCH DAMAGES. + +17. Interpretation of Sections 15 and 16. +If the disclaimer of warranty and limitation of liability provided above cannot be given local legal effect according to their terms, reviewing courts shall apply local law that most closely approximates an absolute waiver of all civil liability in connection with the Program, unless a warranty or assumption of liability accompanies a copy of the Program in return for a fee. + +END OF TERMS AND CONDITIONS + +How to Apply These Terms to Your New Programs + +If you develop a new program, and you want it to be of the greatest possible use to the public, the best way to achieve this is to make it free software which everyone can redistribute and change under these terms. + +To do so, attach the following notices to the program. It is safest to attach them to the start of each source file to most effectively state the exclusion of warranty; and each file should have at least the “copyright” line and a pointer to where the full notice is found. + + + Copyright (C) + + This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. + + This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. + + You should have received a copy of the GNU General Public License along with this program. If not, see . + +Also add information on how to contact you by electronic and paper mail. + +If the program does terminal interaction, make it output a short notice like this when it starts in an interactive mode: + + Copyright (C) + This program comes with ABSOLUTELY NO WARRANTY; for details type `show w'. + This is free software, and you are welcome to redistribute it under certain conditions; type `show c' for details. + +The hypothetical commands `show w' and `show c' should show the appropriate parts of the General Public License. Of course, your program's commands might be different; for a GUI interface, you would use an “about box”. + +You should also get your employer (if you work as a programmer) or school, if any, to sign a “copyright disclaimer” for the program, if necessary. For more information on this, and how to apply and follow the GNU GPL, see . + +The GNU General Public License does not permit incorporating your program into proprietary programs. If your program is a subroutine library, you may consider it more useful to permit linking proprietary applications with the library. If this is what you want to do, use the GNU Lesser General Public License instead of this License. But first, please read . From 08dcd477aa68d90b1f314f24856763d2c193ee6b Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Mon, 8 Apr 2024 16:48:33 +0200 Subject: [PATCH 07/10] SFT-3538: Add foundation-firmware crate. * Cargo.toml (workspace.dependencies): Add nom and secp256k1. * firmware/Cargo.toml: New cargo package. * firmware/src/lib.rs: New library file. --- Cargo.toml | 4 + firmware/Cargo.toml | 27 ++ firmware/src/bin/foundation-firmware.rs | 91 ++++ firmware/src/lib.rs | 554 ++++++++++++++++++++++++ 4 files changed, 676 insertions(+) create mode 100644 firmware/Cargo.toml create mode 100644 firmware/src/bin/foundation-firmware.rs create mode 100644 firmware/src/lib.rs diff --git a/Cargo.toml b/Cargo.toml index c39f2f5..19419dc 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -7,6 +7,7 @@ members = [ "arena", "codecs", "ffi", + "firmware", "test-vectors", "ur", "urtypes", @@ -17,6 +18,7 @@ members = [ homepage = "https://github.com/Foundation-Devices/foundation-rs" [workspace.dependencies] +anyhow = "1.0.83" arbitrary = { version = "1", features = ["derive"] } bech32 = { version = "0.9", default-features = false } bip39 = { version = "2", default-features = false } @@ -30,8 +32,10 @@ hex = { version = "0.4.2", default-features = false } itertools = { version = "0.10", default-features = false } libfuzzer-sys = "0.4" minicbor = { version = "0.20", features = ["derive"] } +nom = { version = "7", default-features = false } phf = { version = "0.11", features = ["macros"], default-features = false } rand_xoshiro = "0.6" +secp256k1 = { version = "0.29", default-features = false } serde = { version = "1.0.156", features = ["derive"] } serde_json = "1" uuid = { version = "1", default-features = false } diff --git a/firmware/Cargo.toml b/firmware/Cargo.toml new file mode 100644 index 0000000..b58d0a0 --- /dev/null +++ b/firmware/Cargo.toml @@ -0,0 +1,27 @@ +# SPDX-FileCopyrightText: © 2024 Foundation Devices, Inc. +# SPDX-License-Identifier: GPL-3.0-or-later + +[package] +name = "foundation-firmware" +version = "0.1.0" +description = "Firmware image format" +homepage.workspace = true +edition = "2021" +license = "GPL-3.0-or-later AND GPL-3.0-only" + +[[bin]] +name = "foundation-firmware" +required-features = ["binary"] + +[features] +default = ["std", "binary"] +std = ["hex?/std", "nom/std", "secp256k1/std"] +binary = ["anyhow", "hex", "secp256k1/global-context", "std"] + +[dependencies] +bitcoin_hashes = { workspace = true } +heapless = { workspace = true } +hex = { workspace = true, optional = true } +nom = { workspace = true } +secp256k1 = { workspace = true } +anyhow = { workspace = true, optional = true } diff --git a/firmware/src/bin/foundation-firmware.rs b/firmware/src/bin/foundation-firmware.rs new file mode 100644 index 0000000..0214065 --- /dev/null +++ b/firmware/src/bin/foundation-firmware.rs @@ -0,0 +1,91 @@ +// SPDX-FileCopyrightText: © 2024 Foundation Devices, Inc. +// SPDX-License-Identifier: GPL-3.0-or-later + +use anyhow::{anyhow, bail, Context, Result}; +use bitcoin_hashes::{sha256, sha256d, Hash, HashEngine}; +use foundation_firmware::{header, verify_signature, Information, HEADER_LEN}; +use nom::Finish; +use secp256k1::global::SECP256K1; +use std::fs; + +fn main() -> Result<()> { + let file_name = std::env::args_os() + .nth(1) + .ok_or_else(|| anyhow!("provide a file name"))?; + + let file_buf = fs::read(file_name).context("failed to read firmware")?; + + let header_len = usize::try_from(HEADER_LEN).unwrap(); + let header = match header(&file_buf[..header_len]).finish() { + Ok((_, hdr)) => hdr, + Err(_) => bail!("failed to parse firmware header"), + }; + + header.verify().context("header verification failed")?; + + let file_hash = sha256::Hash::hash(&file_buf); + let build_hash = sha256::Hash::hash(&file_buf[header_len..]); + + let mut engine = sha256d::Hash::engine(); + engine.input(&header.information.serialize()); + engine.input(&file_buf[header_len..]); + let validation_hash = sha256d::Hash::from_engine(engine); + + // This one is just for debugging. + let mut engine = sha256::Hash::engine(); + engine.input(&header.information.serialize()); + engine.input(&file_buf[header_len..]); + let single_hash = sha256::Hash::from_engine(engine); + + let firmware_length = file_buf.len() - header_len; + if firmware_length != usize::try_from(header.information.length).unwrap() { + bail!( + "invalid specified firmware length, on disk size is {}, specified one {}", + firmware_length, + header.information.length + ); + } + + let signature1 = header.signature.signature1.serialize_compact(); + let signature2 = header.signature.signature2.serialize_compact(); + + println!("Firmware:"); + println!( + "{:>17}: {:#08X} ({}) ", + "Magic", + header.information.magic, + if header.information.magic == Information::MAGIC_COLOR { + "color" + } else { + "mono" + }, + ); + println!("{:>17}: {}", "Timestamp", header.information.timestamp); + println!("{:>17}: {}", "Date", header.information.date); + println!("{:>17}: {}", "Version", header.information.version); + println!("{:>17}: {} bytes", "Length", header.information.length); + println!("{:>17}: {}", "Key", header.signature.public_key1); + println!("{:>17}: {}", "Signature", hex::encode(signature1)); + println!("{:>17}: {}", "Key", header.signature.public_key2); + println!("{:>17}: {}", "Signature", hex::encode(signature2)); + println!("{:>17}: {}", "File Hash", file_hash); + println!("{:>17}: {}", "Build Hash", build_hash); + println!( + "{:>17}: {}", + "Validation Hash", + hex::encode(validation_hash.to_byte_array()) + ); + println!( + "{:>17}: {}", + "Single Hash", + hex::encode(single_hash.to_byte_array()) + ); + println!(); + + verify_signature(&SECP256K1, &header, &validation_hash, None) + .context("firmware signature verification failed.")?; + + println!("Firmware signature is valid!"); + + Ok(()) +} diff --git a/firmware/src/lib.rs b/firmware/src/lib.rs new file mode 100644 index 0000000..7983193 --- /dev/null +++ b/firmware/src/lib.rs @@ -0,0 +1,554 @@ +// SPDX-FileCopyrightText: © 2024 Foundation Devices, Inc. +// SPDX-License-Identifier: GPL-3.0-or-later +// +// SPDX-FileCopyrightText: 2018 Coinkite, Inc. +// SPDX-License-Identifier: GPL-3.0-only + +//! Firmware images verification. + +#![cfg_attr(not(feature = "std"), no_std)] +#![warn(missing_docs)] + +use bitcoin_hashes::{sha256d, Hash}; +use heapless::{String, Vec}; +use nom::IResult; +use secp256k1::{ecdsa, Message, PublicKey, Secp256k1, Verification}; + +/// Length of the header, in bytes. +pub const HEADER_LEN: u32 = 2048; + +/// Length of the firmware date in bytes. +pub const DATE_LEN: usize = 14; + +/// Length of the firmware version, in bytes. +pub const VERSION_LEN: usize = 8; + +/// Maximum length of the firmware, in bytes. +pub const MAX_LEN: u32 = (1792 * 1024) - 256; + +/// Magic value to indicate that the index in the public key is indicating +/// a self signed firmware. +pub const USER_KEY: u32 = 255; + +/// See [`foundation_public_keys`] for information. +const FOUNDATION_PUBLIC_KEYS: [[u8; 65]; 4] = [ + // Key: 00-pub.bin + [ + 0x04, 0xdd, 0x60, 0x31, 0xc6, 0x40, 0x98, 0x99, 0xcf, 0x7f, 0x7b, 0xc3, 0x47, 0x96, 0xac, + 0x92, 0xe4, 0x44, 0x36, 0x59, 0x53, 0x49, 0x9b, 0x94, 0x36, 0xfc, 0x94, 0x40, 0x59, 0xc4, + 0x9b, 0x0e, 0x6a, 0x45, 0x91, 0x29, 0x8c, 0xa8, 0x36, 0x7e, 0x3a, 0x14, 0xe5, 0x13, 0x72, + 0xb2, 0x74, 0xf3, 0xe8, 0x07, 0x1b, 0x21, 0xfd, 0x3d, 0xed, 0xd7, 0xa2, 0xe2, 0x7b, 0xe8, + 0x94, 0x4c, 0x02, 0x7e, 0x01, + ], + // Key: 01-pub.bin + [ + 0x04, 0xc6, 0xcd, 0xf9, 0xf6, 0x35, 0x31, 0xe7, 0x67, 0x5b, 0x55, 0x35, 0x9e, 0xb7, 0xe5, + 0xca, 0x1f, 0xb9, 0x84, 0x76, 0x54, 0x02, 0xc4, 0xac, 0xb1, 0x53, 0x5e, 0xcb, 0x5b, 0xd9, + 0xd7, 0xb5, 0x8e, 0x81, 0xe1, 0x51, 0xa6, 0xc5, 0xbe, 0x87, 0x94, 0xa9, 0x9c, 0x6f, 0x82, + 0xb0, 0xe3, 0xb4, 0x53, 0x04, 0xf0, 0xa0, 0x48, 0x7b, 0xb2, 0x2a, 0xe2, 0x1d, 0x26, 0xfa, + 0xb7, 0x18, 0xb9, 0x32, 0xf9, + ], + // Key: 02-pub.bin + [ + 0x04, 0xea, 0xe2, 0xa4, 0xf7, 0x90, 0x3f, 0xc7, 0xa6, 0x02, 0x58, 0x1f, 0x16, 0x36, 0x49, + 0xba, 0xbb, 0x72, 0xf4, 0xd3, 0x58, 0x8a, 0x2a, 0xd0, 0x34, 0xae, 0x63, 0xbd, 0x18, 0x9e, + 0xb0, 0x9c, 0xe9, 0x19, 0xce, 0x27, 0xc1, 0x40, 0x15, 0x91, 0xbc, 0x56, 0x64, 0xf5, 0x8d, + 0x70, 0xb1, 0x38, 0x28, 0x77, 0x50, 0x80, 0xb1, 0x3d, 0x0f, 0x93, 0xe6, 0xc8, 0xa9, 0x83, + 0xe8, 0x70, 0xc2, 0xbe, 0xad, + ], + // Key: 03-pub.bin + [ + 0x04, 0xca, 0x32, 0xae, 0xb0, 0xf2, 0x25, 0x7f, 0xa2, 0x0c, 0xac, 0x3a, 0x56, 0xa5, 0x8b, + 0x97, 0xde, 0x99, 0x30, 0xef, 0x14, 0xfd, 0xd6, 0x90, 0x5d, 0x6d, 0x6e, 0x40, 0xb8, 0x30, + 0x98, 0xc1, 0x3e, 0x99, 0x77, 0x25, 0xdb, 0x1c, 0xbe, 0x4d, 0x9b, 0x1b, 0x8a, 0x54, 0x63, + 0x0e, 0x89, 0x4b, 0x3e, 0x23, 0x52, 0x2e, 0x5e, 0x14, 0xf3, 0x7e, 0xbb, 0x3e, 0xd9, 0xae, + 0x6e, 0xda, 0xa1, 0xba, 0xcd, + ], +]; + +/// Maximum index in the [`Signature::public_key1`] and +/// [`Signature::public_key2`] fields if it isn't an user key ([`USER_KEY`]). +pub const MAX_PUBLIC_KEYS: u32 = FOUNDATION_PUBLIC_KEYS.len() as u32; + +/// The header of the firmware. +#[derive(Debug)] +pub struct Header { + /// Firmware information. + pub information: Information, + /// Signatures data. + pub signature: Signature, +} + +impl Header { + /// Verify that the header is well-formed. + pub fn verify(&self) -> Result<(), VerifyHeaderError> { + match self.information.magic { + Information::MAGIC_MONO | Information::MAGIC_COLOR => (), + _ => return Err(VerifyHeaderError::UnknownMagic(self.information.magic)), + }; + + if self.information.timestamp == 0 { + return Err(VerifyHeaderError::InvalidTimestamp); + } + + if self.information.length < HEADER_LEN { + return Err(VerifyHeaderError::FirmwareTooSmall(self.information.length)); + } + + if self.information.length > MAX_LEN { + return Err(VerifyHeaderError::FirmwareTooBig(self.information.length)); + } + + if !self.is_signed_by_user() { + if self.signature.public_key1 > MAX_PUBLIC_KEYS { + return Err(VerifyHeaderError::InvalidPublicKey1Index( + self.signature.public_key1, + )); + } + + if self.signature.public_key2 > MAX_PUBLIC_KEYS { + return Err(VerifyHeaderError::InvalidPublicKey2Index( + self.signature.public_key2, + )); + } + + if self.signature.public_key1 == self.signature.public_key2 { + return Err(VerifyHeaderError::SamePublicKeys( + self.signature.public_key1, + )); + } + } + + Ok(()) + } + + /// Returns `true` if the firmware was signed by the user and not a + /// Foundation approved key. + /// + /// # See also + /// + /// - [`foundation_public_keys`]. + pub fn is_signed_by_user(&self) -> bool { + self.signature.public_key1 == USER_KEY + } +} + +/// Firmware information. +#[derive(Debug)] +pub struct Information { + /// Magic bytes value. + pub magic: u32, + /// The time stamp of the firmware. + pub timestamp: u32, + /// The date of the firmware as a string. + pub date: String, + /// Version of the firmware as a string. + pub version: String, + /// The length of the firmware, in bytes. + pub length: u32, +} + +impl Information { + /// Magic constant for mono devices. + pub const MAGIC_MONO: u32 = 0x50415353; + /// Magic constant for color devices. + pub const MAGIC_COLOR: u32 = 0x53534150; + /// The size of this structure when serialized, in bytes. + pub const LEN: usize = (4 * 2) + DATE_LEN + VERSION_LEN + 4; + + /// Serialize the structure. + pub fn serialize(&self) -> [u8; Self::LEN] { + let mut off = 0; + let mut buf = [0; Self::LEN]; + + buf[off..off + 4].copy_from_slice(&self.magic.to_le_bytes()); + off += 4; + + buf[off..off + 4].copy_from_slice(&self.timestamp.to_le_bytes()); + off += 4; + + buf[off..off + self.date.len()].copy_from_slice(self.date.as_bytes()); + off += self.date.len(); + + // Fill with zeroes the rest of the date. + buf[off..off + (DATE_LEN - self.date.len())].fill(0); + off += DATE_LEN - self.date.len(); + + buf[off..off + self.version.len()].copy_from_slice(&self.version.as_bytes()); + off += self.version.len(); + + // Fill with zeroes the rest of the version. + buf[off..off + (VERSION_LEN - self.version.len())].fill(0); + off += VERSION_LEN - self.version.len(); + + buf[off..off + 4].copy_from_slice(&self.length.to_le_bytes()); + + buf + } +} + +/// Firmware signature information. +/// +/// The public key indexes are indexes of the [`foundation_public_keys`] +/// array. +#[derive(Debug)] +pub struct Signature { + /// The first public key index. + pub public_key1: u32, + /// The signature of the firmware associated with the first public key. + pub signature1: ecdsa::Signature, + /// The second public key index. + pub public_key2: u32, + /// The signature of the firmware associated with the second public key. + pub signature2: ecdsa::Signature, +} + +impl Signature { + /// Return the first public key. + /// + /// # Panics + /// + /// This function can panic if `public_key1` is out of range. The header + /// should have been verified before with [`Header::verify`]. + pub fn public_key1(&self) -> PublicKey { + let public_keys = foundation_public_keys(); + public_keys[usize::try_from(self.public_key1).unwrap()] + } + + /// Return the second public key. + /// + /// # Panics + /// + /// This function can panic if `public_key2` is out of range. The header + /// should have been verified before with [`Header::verify`]. + pub fn public_key2(&self) -> PublicKey { + let public_keys = foundation_public_keys(); + public_keys[usize::try_from(self.public_key2).unwrap()] + } +} + +/// Errors that can happen when verifying the firmware header. +#[derive(Debug)] +pub enum VerifyHeaderError { + /// Unknown magic bytes. + UnknownMagic(u32), + /// The time stamp is invalid. + InvalidTimestamp, + /// The reported firmware image length is too small. + FirmwareTooSmall(u32), + /// The reported firmware image length is too big. + FirmwareTooBig(u32), + /// The first public key index is invalid. + InvalidPublicKey1Index(u32), + /// The second public key index is invalid. + InvalidPublicKey2Index(u32), + /// The firmware was signed with the same key for both signatures. + SamePublicKeys(u32), +} + +impl core::fmt::Display for VerifyHeaderError { + fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { + match self { + VerifyHeaderError::UnknownMagic(magic) => { + write!(f, "invalid magic bytes: {magic:#08X}") + } + VerifyHeaderError::InvalidTimestamp => write!(f, "invalid timestamp"), + VerifyHeaderError::FirmwareTooSmall(size) => { + write!(f, "firmware is too small: {size} bytes") + } + VerifyHeaderError::FirmwareTooBig(size) => { + write!(f, "firmware is too big: {size} bytes") + } + VerifyHeaderError::InvalidPublicKey1Index(index) => { + write!(f, "public key 1 index is out of range: {index}") + } + VerifyHeaderError::InvalidPublicKey2Index(index) => { + write!(f, "public key 2 index is out of range: {index}") + } + VerifyHeaderError::SamePublicKeys(index) => write!( + f, + "the same public key ({index}) was used to sign the firmware." + ), + } + } +} + +#[cfg(feature = "std")] +impl std::error::Error for VerifyHeaderError {} + +/// Parse the firmware's [`Header`]. +pub fn header(i: &[u8]) -> IResult<&[u8], Header> { + nom::combinator::map( + nom::sequence::tuple((information, signature)), + |(information, signature)| Header { + information, + signature, + }, + )(i) +} + +fn information(i: &[u8]) -> IResult<&[u8], Information> { + nom::combinator::map( + nom::sequence::tuple(( + nom::number::complete::le_u32, + nom::number::complete::le_u32, + string::<_, DATE_LEN>, + string::<_, VERSION_LEN>, + nom::number::complete::le_u32, + )), + |(magic, timestamp, date, version, length)| Information { + magic, + timestamp, + date, + version, + length, + }, + )(i) +} + +fn signature(i: &[u8]) -> IResult<&[u8], Signature> { + nom::combinator::map( + nom::sequence::tuple(( + nom::number::complete::le_u32, + compact_signature, + nom::number::complete::le_u32, + compact_signature, + )), + |(public_key1, signature1, public_key2, signature2)| Signature { + public_key1, + signature1, + public_key2, + signature2, + }, + )(i) +} + +fn compact_signature<'a, E>(i: &'a [u8]) -> IResult<&'a [u8], ecdsa::Signature, E> +where + E: nom::error::ParseError<&'a [u8]> + nom::error::FromExternalError<&'a [u8], secp256k1::Error>, +{ + let start_input = i; + let mut buf = [0; 64]; + let (i, ()) = nom::multi::fill(nom::number::complete::u8, &mut buf)(i)?; + ecdsa::Signature::from_compact(&buf) + .map(|v| (i, v)) + .map_err(|e| { + nom::Err::Failure(E::from_external_error( + start_input, + nom::error::ErrorKind::Fail, + e, + )) + }) +} + +fn string<'a, E, const N: usize>(i: &'a [u8]) -> IResult<&'a [u8], String, E> +where + E: nom::error::ParseError<&'a [u8]> + + nom::error::FromExternalError<&'a [u8], core::str::Utf8Error>, +{ + let start_input = i; + let mut buf: Vec = Vec::new(); + buf.resize(N, 0).unwrap(); + let (i, ()) = nom::multi::fill(nom::number::complete::u8, &mut buf)(i)?; + + // Basically strlen. + let len = buf + .iter() + .enumerate() + .find_map(|(i, &b)| if b == b'\0' { Some(i) } else { None }); + + // Return error if the length is unknown. + match len { + Some(len) => buf.truncate(len), + None => { + return Err(nom::Err::Failure(E::from_error_kind( + start_input, + nom::error::ErrorKind::Fail, + ))) + } + } + + String::from_utf8(buf) + .map_err(|e| { + nom::Err::Failure(E::from_external_error( + start_input, + nom::error::ErrorKind::Fail, + e, + )) + }) + // Not really needed but if our tool only uses ASCII character + // validate that instead, simplifies the FFI interface as we + // don't have to handle UTF-8 on the C side of things. + .and_then(|s| { + if s.is_ascii() { + Ok(s) + } else { + Err(nom::Err::Failure(E::from_error_kind( + start_input, + nom::error::ErrorKind::Fail, + ))) + } + }) + .map(|v| (i, v)) +} + +/// Keys that are used in Passport to verify the validity of a firmware, they +/// are in a specific order and map to an index in +pub fn foundation_public_keys() -> [PublicKey; 4] { + [ + PublicKey::from_slice(&FOUNDATION_PUBLIC_KEYS[0]).expect("public key 0 can't be invalid"), + PublicKey::from_slice(&FOUNDATION_PUBLIC_KEYS[1]).expect("public key 1 can't be invalid"), + PublicKey::from_slice(&FOUNDATION_PUBLIC_KEYS[2]).expect("public key 2 can't be invalid"), + PublicKey::from_slice(&FOUNDATION_PUBLIC_KEYS[3]).expect("public key 3 can't be invalid"), + ] +} + +/// Verifies the signature of the firmware. +pub fn verify_signature( + secp: &Secp256k1, + header: &Header, + firmware_hash: &sha256d::Hash, + user_public_key: Option, +) -> Result<(), VerifySignatureError> { + assert!(header.verify().is_ok()); + + let message = Message::from_digest(firmware_hash.to_byte_array()); + + // Perform the signature verification depending on the mode. + match (header.is_signed_by_user(), user_public_key) { + (true, Some(public_key)) => { + // See below on the normal verificationn as to why. + let mut signature1 = header.signature.signature1; + signature1.normalize_s(); + + public_key + .verify(secp, &message, &header.signature.signature1) + .map_err(|error| VerifySignatureError::InvalidUserSignature { + public_key, + signature: header.signature.signature1.clone(), + error, + }) + } + (true, None) => Err(VerifySignatureError::MissingUserPublicKey), + (false, _) => { + // Normalize the signatures as micro-ecc does not normalize the + // signatures and libsecp256k1 (rust-secp256k1) does not accept + // signatures that are not normalized to avoid malleability + // attacks. + // + // This is not a problem for the signatures of the firmware as we + // do not care if the signature changes itself, only that it is + // valid. + let mut signature1 = header.signature.signature1; + let mut signature2 = header.signature.signature2; + signature1.normalize_s(); + signature2.normalize_s(); + + header + .signature + .public_key1() + .verify(secp, &message, &signature1) + .map_err(|error| VerifySignatureError::FailedSignature1 { + index: header.signature.public_key1, + signature: header.signature.signature1, + error, + })?; + + header + .signature + .public_key2() + .verify(secp, &message, &signature2) + .map_err(|error| VerifySignatureError::FailedSignature2 { + index: header.signature.public_key2, + signature: header.signature.signature2, + error, + })?; + + Ok(()) + } + } +} + +/// Errors that can happen when verifying the firmware signatures. +#[derive(Debug)] +pub enum VerifySignatureError { + /// The user signed firmware is not valid. + InvalidUserSignature { + /// The public key of the user. + public_key: PublicKey, + /// The signature of the firmware. + signature: ecdsa::Signature, + /// The signtature verification error. + error: secp256k1::Error, + }, + /// The first signature verification failed. + FailedSignature1 { + /// The index of the public key used. + index: u32, + /// The signature of the firmware. + signature: ecdsa::Signature, + /// The signtature verification error. + error: secp256k1::Error, + }, + /// The second signature verification failed. + FailedSignature2 { + /// The index of the public key used. + index: u32, + /// The signature of the firmware. + signature: ecdsa::Signature, + /// The signtature verification error. + error: secp256k1::Error, + }, + /// The firmware was signed by the user but no user public key was found. + MissingUserPublicKey, +} + +impl core::fmt::Display for VerifySignatureError { + fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { + match self { + VerifySignatureError::InvalidUserSignature { .. } => { + write!(f, "invalid user signature") + } + VerifySignatureError::FailedSignature1 { .. } => write!(f, "first signature failed"), + VerifySignatureError::FailedSignature2 { .. } => write!(f, "second signature failed"), + VerifySignatureError::MissingUserPublicKey => { + write!(f, "firmware is user signed but user public key is missing") + } + } + } +} + +#[cfg(feature = "std")] +impl std::error::Error for VerifySignatureError { + fn source(&self) -> Option<&(dyn std::error::Error + 'static)> { + match self { + VerifySignatureError::InvalidUserSignature { error, .. } => Some(error), + VerifySignatureError::FailedSignature1 { error, .. } => Some(error), + VerifySignatureError::FailedSignature2 { error, .. } => Some(error), + _ => None, + } + } +} + +#[cfg(test)] +mod tests { + use super::*; + + #[test] + fn test_constants_consistency() { + // Originally the date field was designed to hold that string. + assert_eq!(DATE_LEN, b"Jan. 01, 2021".len() + 1); + + // These are the same. + assert_eq!(foundation_public_keys().len(), 4); + assert_eq!(FOUNDATION_PUBLIC_KEYS.len(), 4); + assert_eq!(MAX_PUBLIC_KEYS, 4); + assert_eq!(Information::LEN, 34); // Should be equal to sizeof(fw_info_t) + } + + // Just check that we don't panic. + #[test] + fn foundation_keys_to_typed_secp256k1_public_key() { + foundation_public_keys(); + } +} From 4f12010f21de64b442d3b54cc48ba325538dfb88 Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 20:19:56 +0200 Subject: [PATCH 08/10] SFT-3538: Ignore firmware files. * .gitignore (*.bin): New rule. --- .gitignore | 3 +++ firmware/src/lib.rs | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 5daf2cb..28cb524 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3 +12,6 @@ target/ # CMake **/cmake-build-debug + +# Firmware files. +*.bin diff --git a/firmware/src/lib.rs b/firmware/src/lib.rs index 7983193..326434b 100644 --- a/firmware/src/lib.rs +++ b/firmware/src/lib.rs @@ -408,7 +408,7 @@ pub fn verify_signature( secp: &Secp256k1, header: &Header, firmware_hash: &sha256d::Hash, - user_public_key: Option, + user_public_key: Option<&PublicKey>, ) -> Result<(), VerifySignatureError> { assert!(header.verify().is_ok()); @@ -424,7 +424,7 @@ pub fn verify_signature( public_key .verify(secp, &message, &header.signature.signature1) .map_err(|error| VerifySignatureError::InvalidUserSignature { - public_key, + public_key: public_key.clone(), signature: header.signature.signature1.clone(), error, }) From ef5d55c7087b7c50ec6088dad9dcfb012d0b051e Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 20:26:17 +0200 Subject: [PATCH 09/10] SFT-3538: Fix hex-conservative minimal versions. * .github/workflows/dependencies.yaml (are-versions-really-minimal): Pin arrayvec version to 0.7.4. --- .github/workflows/dependencies.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/dependencies.yaml b/.github/workflows/dependencies.yaml index 1ef90b3..ddd9fa3 100644 --- a/.github/workflows/dependencies.yaml +++ b/.github/workflows/dependencies.yaml @@ -38,4 +38,6 @@ jobs: # # This is not needed for stable versions. - run: cargo update -p proc-macro2 --precise 1.0.66 -Z minimal-versions + # hex-conservative uses wrong minimal versions. + - run: cargo update -p arrayvec --precise 0.7.4 -Z minimal-versions - run: cargo check -Z minimal-versions From 84faf84f3858f0f549ee67f6187f90f3075b3cfb Mon Sep 17 00:00:00 2001 From: Jean-Pierre De Jesus DIAZ Date: Thu, 9 May 2024 21:46:56 +0200 Subject: [PATCH 10/10] SFT-3538: Bump foundation-ur to 0.2.0. * ur/Cargo.toml (package) : Bump to 0.2.0. --- ur/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ur/Cargo.toml b/ur/Cargo.toml index b98c7a4..ca22ee6 100644 --- a/ur/Cargo.toml +++ b/ur/Cargo.toml @@ -14,7 +14,7 @@ with static memory allocation for embedded devices while also allowing to use dynamic memory allocation for platforms with more resources. """ homepage.workspace = true -version = "0.1.0" +version = "0.2.0" edition = "2021" license = "MIT"