Typescript

[prbxr]

Hello

I am using your wonderful library!
Would you like to update

export declare function model<S extends Obj, K extends keyof S, A extends FnMap = {}, V extends FnMap = {}>(name: string, { initial, actions, views }: ModelArgs<S, A, V>): (obj?: object | undefined) => S & A & V & Model<S>;

to this obj?: S | undefined

export declare function model<S extends Obj, K extends keyof S, A extends FnMap = {}, V extends FnMap = {}>(name: string, { initial, actions, views }: ModelArgs<S, A, V>): (obj?: S | undefined) => S & A & V & Model<S>;

And setting initial as optional, here:

export declare type ModelArgs<S extends Obj, A extends FnMap, V extends FnMap> = {
    initial: () => S;
    actions?: (self: S & Model<S>) => A;
    views?: (self: S & Model<S>) => V;
};

[prbxr]

I can do the PR

[prbxr]

and K extends keyof S = keyof S

export declare function model<S extends Obj, K extends keyof S = keyof S, A extends FnMap = {}, V extends FnMap = {}>(name: string, { initial, actions, views }: ModelArgs<S, A, V>): (obj?: S | undefined) => S & A & V & Model<S>;

in order to do

export const ProductModel = model<TProduct>('Product', {
    actions: (state) => ({
        setSelected: (isSelected: boolean) => {
            state.isSelected = isSelected
        },
    }),
})

[prbxr]

Another problem:
state.getParent() is not typed
is there a way to type it?

[prbxr]

views also not typed

[ForsakenHarmony]

Hey @prbxr not sure how I feel about making initial optional, that would kinda require obj to be required

I could imagine passing obj to initial if that's something that would help you (you could just pass through at that point)

let example = model('example', { initial: (param: { prop: boolean }) => param });
//                                         ^                            ^ `S` inferred from here
//                                         | something like `Partial<S>`
example({ prop: true });

K extends keyof S = keyof S

sure

Another problem:
state.getParent() is not typed
is there a way to type it?

It's hard, because it's not fixed
You can use state.getParent() as Model<AnotherModel>

views also not typed

Views are not typed?