Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Infer changeId in a non-caught-up branch PR #49

Open
1 task
ryan-roemer opened this issue May 26, 2022 · 0 comments
Open
1 task

Bug: Infer changeId in a non-caught-up branch PR #49

ryan-roemer opened this issue May 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ryan-roemer
Copy link
Member

When we have an unmergeable / out-of-sync branch in an open PR, formideploy doesn't infer changeId correctly and skips the staging deploy. See, e.g. https://github.com/FormidableLabs/spectacle/runs/6582133835

[config] Full configuration: 
{
  "lander": {
    "name": "spectacle"
  },
  "github": {
    "org": "FormidableLabs",
    "repo": "spectacle"
  },
  "build": {
    "dir": "build",
    "path": "build/open-source/spectacle",
    "jobId": "2378867420",
    "jobUrl": "https://github.com/FormidableLabs/spectacle/actions/runs/2378867420",
    "changeId": null,
    "isPullRequest": false
  },
  "site": {
    "basePath": "open-source/spectacle",
    "redirects": {},
    "excludes": []
  },
  "staging": {
    "domain": "formidable-com-spectacle-staging-null.surge.sh"
  },
  "production": {
    "domain": "formidable.com",
    "bucket": "formidable.com",
    "region": "us-east-1"
  }
}

[formideploy] Starting {"action":"staging"} with options 
{
  "port": 5000,
  "limit": 10,
  "start": "2022-05-24T21:44:09.045Z",
  "dryrun": false,
  "production": false,
  "staging": true
}

[deploy:staging] Skipping deployment (CI): CI did not provide a build.changeId value (e.g., merge or master build)

Task:

  • Infer changeId in GH actions for unmergeable PR branches.
@ryan-roemer ryan-roemer added the bug Something isn't working label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant