Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hostname is not honoured in applets #20

Closed
puria opened this issue Nov 30, 2023 · 0 comments · Fixed by #25
Closed

The hostname is not honoured in applets #20

puria opened this issue Nov 30, 2023 · 0 comments · Fixed by #25
Assignees
@bbtgnn

Comments

@puria
Copy link
Member

puria commented Nov 30, 2023

It should be in the endpoint /GET o /POST inside the html... but localhost is always called!

https://github.com/ForkbombEu/ncr/blob/main/src/index.ts#L159
@bbtgnn bbtgnn linked a pull request Dec 6, 2023 that will close this issue
fix: use config.hostname instead of localhost in applets url #25
Merged
@puria puria closed this as completed in #25 Dec 6, 2023
puria pushed a commit that referenced this issue Dec 6, 2023
@bbtgnn
fix: remove localhost string (#25)
7fc4b1f 
closes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbtgnn bbtgnn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use config.hostname instead of localhost in applets url ForkbombEu/ncr
2 participants
@puria @bbtgnn