Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom structures generator [Main task] #158

Open
atherdon opened this issue Apr 17, 2019 · 117 comments
Open

custom structures generator [Main task] #158

atherdon opened this issue Apr 17, 2019 · 117 comments
Assignees
Milestone

Comments

@atherdon
Copy link
Contributor

atherdon commented Apr 17, 2019

So, we have our fetch module.
link: https://github.com/GroceriStar/groceristar-fetch (Check Readme there and 5 published articles). And it's an old plugin that we build with Vadim during the last 8 months. Right now it's time for changes, and we split fetch with sd repository into 2 parts, that is separated.
It makes the code more robust and easy to maintain/extend the code.

actually, with changes from me, @hirdbluebird, @azaidi4, @EbrahimKreem we break fetch and fixing it right now...

So, the main reason why I mentioning all of you here is:

  1. we'll move from fetch to sd repository part of the functionality, that will generate us the same data, BUT with different structures(like {a:a, b:b} to {a:a, more: {b:b}}). All of you have different skills and knowledge of our modules, so we'll need to split this big task into small chunks.

  2. Vadim will curate all of you, so please notify him frequently. The same thing with code - as we'll have a lot of people that code here at the same time --> we need to sync your forks frequently. If there is some troubles with your knowledge with git/github - please mention this. it's not a problem and i'll help you to master it.

  3. Elnur will work with tests, Ronnie will help him
    Wahaj right now dealing with the generation of a few files,
    Ahmad and Ebrahim, Eugene came from fetch repository, so they know about different methods that we have there.

Vadim knows everything about both of this repositories, so he is in charge.

Ask your questions

@azaidi4, @EbrahimKreem, @vadim9999, @ronniebhatt, @elnur004

@atherdon
Copy link
Contributor Author

atherdon commented Apr 18, 2019

✔️ Current task for @elnur004 is #135. @vadim9999 can you have a look, please?

@atherdon
Copy link
Contributor Author

atherdon commented Apr 18, 2019

✔️ Current task for @wahaj-47(sorry that i forget to add you here) is #55. @vadim9999 please take a look, because i didn't test your generator myself

@wahaj-47
Copy link
Collaborator

wahaj-47 commented Apr 21, 2019

✔️ #173 both measurement files are being generated.

@atherdon
Copy link
Contributor Author

atherdon commented Apr 22, 2019

#173 both measurement files are being generated.

@vadim9999 please check it/ task is here #55 ✔️ I add you as admin to this repository. so you'll be able to merge PRs

@atherdon
Copy link
Contributor Author

@EbrahimKreem & @azaidi4 are you here with us?

@azaidi4
Copy link
Collaborator

azaidi4 commented Apr 22, 2019

@atherdon yes. Just been a bit busy. Will start working on this soon

@hirdbluebird
Copy link
Collaborator

hirdbluebird commented Apr 22, 2019

@vadim9999
Hi.
what should be done in this repo? Any actual tasks?
Also, can you please create a task about updating README.md? Not clear what the purpose of this repo and what should be done here. No introduction info here.

@atherdon
Copy link
Contributor Author

i think Elnur and Wahaj as major devs here can help with readme ;)

@vadim9999
Copy link
Collaborator

vadim9999 commented Apr 22, 2019

✔️ @hirdbluebird I have created but now it's empty #176 :)

@vadim9999
Copy link
Collaborator

@ronniebhatt Hi!

@atherdon
Copy link
Contributor Author

atherdon commented May 6, 2019

Guys, I was absent last month as you may find. But was "spying" on your code and pull requests

xxx

Vadim will continue to supervising you here, but I'll work on some management as well. If someone have some ideas about what I/we can update/upgrade in order to make our work more smooth - please tell me. I find out that we don't have a proper Readme here - will update it and make more detailed and easy to navigate.

Btw, nice progress @vadim9999, @elnur004, @wahaj-47, @EbrahimKreem !

@atherdon
Copy link
Contributor Author

atherdon commented May 6, 2019

Question: I see that generator it's become a huge thing here. At it complicate our code/logic here. Is it a good idea to move a generator away as a separated module and just call it in our package.json? #332

@atherdon
Copy link
Contributor Author

atherdon commented May 6, 2019

:shipit: #266

@vadim9999
Copy link
Collaborator

Question: I see that generator it's become a huge thing here. At it complicate our code/logic here. Is it a good idea to move a generator away as a separated module and just call it in our package.json?

Yes, I think it's a good idea

@atherdon
Copy link
Contributor Author

atherdon commented May 7, 2019 via email

@atherdon
Copy link
Contributor Author

atherdon commented May 7, 2019

Team, please welcome Adebowale(@Edebo) - he is our new team member. @vadim will supervise you at this repository.

xxx

@vadim9999
Copy link
Collaborator

vadim9999 commented May 7, 2019

@atherdon are we moving all methods from fetch? Then we will generate files from this functions?

@atherdon
Copy link
Contributor Author

atherdon commented May 7, 2019

@atherdon are we moving all methods from fetch? Then we will generate files from this functions?

I don't think that we need 100% of methods from fetch actually. same with tests.
Here we need to have only methods, that changing/updating structure of our json arrays.
So, for example - i think we need to move most of methods from folder GraphQL because most of them generating arrays. if you want more details, let's have a separated task, where we can discuss each method separately.

@atherdon
Copy link
Contributor Author

atherdon commented May 7, 2019

I think Gracia(@ladysequel) is also ready to start with us

xxx

@atherdon
Copy link
Contributor Author

atherdon commented May 7, 2019

Welcome Pratiksha (@Pratikshagit) as our new member too! She came from apps field with good knowledge at testing. We'll help her to learn Jest, so our test coverage will be awesome.

xxx

@Edebo
Copy link
Contributor

Edebo commented May 8, 2019

Team, please welcome Adebowale(@Edebo) - he is our new team member. @vadim will supervise you at this repository.

xxx
Hi everyone

@atherdon
Copy link
Contributor Author

atherdon commented May 8, 2019

Whuh, looks like we increasing our team quickly. Nathaniel(@dctalk1234) also joining this repository

xxx

@atherdon atherdon added this to the Generator milestone May 8, 2019
@dctalk1234
Copy link

@vadim9999 I was told to get in touch about what tasks you may have for me to start looking at.

@vadim9999
Copy link
Collaborator

vadim9999 commented May 9, 2019

:shipit: @dctalk1234 Hi! This task is for you #282

@Edebo
Copy link
Contributor

Edebo commented May 9, 2019

@vadim9999 i have not got a task yet

@vadim9999
Copy link
Collaborator

vadim9999 commented May 9, 2019

✔️ @Edebo Hi! This task for you #253

@atherdon
Copy link
Contributor Author

If someone want to read more - actually more about plans that we have at fetch plugin located here and at Readme of fetch plugin: GroceriStar/groceristar-fetch#174
And we're doing right now part that we start to work at January: GroceriStar/groceristar-fetch#174 (comment)

@atherdon
Copy link
Contributor Author

The generator is a huge thing. So maybe details are necessary.

Graphql subproject.
our task for it is to generate about 5-8 files, that we're generating here.
Methods we actually grabbing and moving from fetch module.


ChickenKyiv subproject it's using at recipe-antd, fake-API


Groceristar subproject - used at groceristar-showcase, main groceristar-backend server.


Units - Wahaj started to work on it. We generated files. We need methods for it.


Recipe Search - it's part of recipe-API, so it's used a similar DB-schema. Same data used in our recipe-box React Components, aka Selects, Website blocks.


We also need to move some (not all) tests from fetch, because it's part of our current functionality. We just make our code, better and simpler.


Cups.js, that was created by Elnur from scratch(thanks for this). It's
actually part of measurements system, that will be later integrated together.


Meal Calendar: it's actually part of recipe-API server(groceristar is actually part of recipe-API as well, but right now we're not ready to merge them)/

the calendar will display recipes by days. Right now it's a low level of priority, but maybe by simplifying our code, we will be able to able to make it work faster.


Measurements/Unit Conversion is also part of recipe-API and partially to groceristar, later will be integrated with recipes objects.


Nutritions it's also a part of recipe-API and it's important for projects. that rely on nutritional values, like diets.


JsonValidator - > we didn't implement it yet. But it a very important part of the generator. Because we need to validate our file schemes, especially while files have data inside in minified way(which is good)


Separation like how we did it -> will help us later to work on translating this data to other languages.
Because right now we only work with English and this is not cool. like if someone from France - he wouldn't be able totally to use it and benefit from our work

@ijb87
Copy link

ijb87 commented May 11, 2019

Can I have a task please?

@ghost
Copy link

ghost commented Aug 7, 2019

Hi, I'm Edward. Looking forward to working with you all!

@anh212
Copy link

anh212 commented Aug 15, 2019

Hello everyone, my name is Andrew and I am excited to learn and further develop my skills with all of you!

@SyeedHasan
Copy link

Hi guys, I'm Syed. Looking forward to furnishing my development skills with all of you. I'll get started with the project and jump right in to developing some feature soon!

@vadim9999
Copy link
Collaborator

Hi!

@MinahilOvais
Copy link

Hi, I'm Minahil. Looking forward to learning and working with you all!

@oksanafrankiv
Copy link

Hi! I'm Oksana. I'm excited to learn and work with all of you!

@haoyxc
Copy link

haoyxc commented Aug 18, 2019

Hi I'm Cindy! Excited to be a part of this!

@zhangted
Copy link

Hey, I'm Ted

@Mishra121
Copy link

Mishra121 commented Sep 15, 2019

Hello I'm Vibhu. I am from India. I have JavaScript development knowledge. Familiar with MERN stack. Hoping to learn a lot from you guys and want to contribute in the project

@parthparmar7
Copy link

Hello I am Parth, I am from India. I have JavaScript knowledge and have knowledge of Vue and Node.

Excited to be here.

@chrissmith012
Copy link

Hello everyone, my name is Chris and I am from the United States. Excited to work and learn with you all!

@atherdon
Copy link
Contributor Author

atherdon commented Oct 6, 2019

@Mishra121 @parthparmar7 @chrissmith012 team, do you have tasks?

@Abobos
Copy link

Abobos commented Oct 7, 2019

Hello everyone @here. My name is Blessing, I'm from Nigeria. A JavaScript Developer (React/Redux + Node.js/Express.js) poised in contributing to @atherdon project.

@chrissmith012
Copy link

@atherdon I do not have any tasks.

@sibasish14
Copy link

Hello everyone. My name is Sibasish and I'm from India. I have basic knowledge of HTML, CSS, and JavaScript. I'm eager to learn and contribute to this organization and improve my skills.

@Cerebrovinny
Copy link

Hello,
My name is Vinicius Cardoso and I'm a Computer Engineering student and student at the University of technology of Hong Kong as a Full-stack developer with React, I love Javascript and development, so I'm eager to start this job and learning, to improve my skills.

@gideonnnalue
Copy link

Hello am Gideon from Nigeria. I am a fullstack MERN stack developer and I would love to join the team.

@madalien11
Copy link

Hello everyone, my name is Madi and I'm a Computer Science student at Nazarbayev University, Kazakhstan. Excited to work, learn and improve my skills with you all!

@okpakomarvis
Copy link

Hello guys, My name is Marvis from Nigeria, am a Fullstack web developer , it great to be here

@shravanhariharan2
Copy link

Hello everyone! I'm Shravan from the US and am looking forward to improving my full-stack development skills here and contributing to this organization.

@hanroro
Copy link

hanroro commented Nov 6, 2019

Hello everyone. I am Han, a graduate student in the US majored in Computter Science. Hope to improve my practical front end skills and contribute to this company.

@vuongdennis
Copy link

Whats up guys.
I'm Dennis, an undergraduate student, studying Computer Science in the US. I'm hoping to join this project in order to improve my skills.

@zakariaelas
Copy link

Hello everyone,
I'm Zakaria, a computer science student from Morocco. I'm looking forward to working with you and making the most out of this learning experience.

@tabishnehal
Copy link

tabishnehal commented Nov 11, 2019

hey folks...this is Mohd Tabish,a computer science student from India.Looking forward to work with all of you and gain some knowledge upon working on the project.

@mbanelsonifeanyi
Copy link

Hi Guys!
I am Mba Nelson Ifeanyi, from Nigeria, I love foreign languages and accents. I look forward to learning with you all!

@yashaswisaini
Copy link

yashaswisaini commented Nov 17, 2019

Hi Geeks,
I am Yashaswi Saini from India, I will love to work with you . I want to learn many things. Now it will be fun working with you all.

@yashaswisaini
Copy link

yashaswisaini commented Nov 17, 2019

@atherdon I will start my work from 2nd week of december.

@yashaswisaini
Copy link

@atherdon finally I'm here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests