Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

Support for https embeds #77

Open
andrin-n-dream opened this issue Nov 10, 2016 · 3 comments
Open

Support for https embeds #77

andrin-n-dream opened this issue Nov 10, 2016 · 3 comments

Comments

@andrin-n-dream
Copy link

Full https support would be great, especially for embeds.
We'd love to add the embed to our page, but we only serve via https.

@andrin-n-dream andrin-n-dream changed the title Support for https emeds Support for https embeds Nov 10, 2016
@jcoffland
Copy link
Member

jcoffland commented Nov 10, 2016

I would happily accept a PR for this. I think all that needs to be done is to convert all references to http:// to // in both the HTML and Javascript. Note that this causes the browser to use whatever the active scheme is rather than forcing http.

@andrin-n-dream
Copy link
Author

The problem is see is that the "fah.ws" server (e.g. 171.67.108.158) does not support https.
https only works if all servers that need to be called support https.

@jcoffland
Copy link
Member

The WS could easily be made to respond on the https port, however we would have to also get a signed certificate for that WS. This would conflict with F@H's internal certificate system. The WS already has a certificate but it's generated automatically by our internal software. This internally generated certificate would not play nice with people's browsers. With some effort we could work around this issue but honestly it's not currently high on our priority list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants