Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support try/catch by assuming try branch #1516

Open
paulxshen opened this issue Jul 11, 2024 · 5 comments
Open

Support try/catch by assuming try branch #1516

paulxshen opened this issue Jul 11, 2024 · 5 comments

Comments

@paulxshen
Copy link

Motivation and description

Lots of packages still use try/catch. Normal execution uses try, so we can easily support it by always assuming try branch? Maybe raise a warning of this assumption.

Possible Implementation

No response

@ToucheSir
Copy link
Member

Not sure I understand the request, but I think this is covered by #1474.

@paulxshen
Copy link
Author

Great! Can you update the docs https://fluxml.ai/Zygote.jl/stable/limitations/ ? Also I still see try/catch errors - even when nothing is thrown - will look more into..

@ToucheSir
Copy link
Member

That PR isn't merged. I don't see why the docs would be updated?

@paulxshen
Copy link
Author

Sorry thought it was merged

@Pangoraw
Copy link
Contributor

it should now work in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants