Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Juno dependency conditional #454

Open
tpapp opened this issue Oct 23, 2018 · 4 comments
Open

make Juno dependency conditional #454

tpapp opened this issue Oct 23, 2018 · 4 comments

Comments

@tpapp
Copy link

tpapp commented Oct 23, 2018

Because of a dependency via Juno, using Flux on Julia#master currently suffers from JunoLab/Media.jl#19.

I wonder if dependency on Juno could be made conditional, via Requires. Looking at the code, the only difficulty I see with this is the @progress macro in training.

@MikeInnes
Copy link
Member

We should probably just fix that issue, rather than introducing something more fragile into Flux.

@pfitzseb
Copy link

Could also switch to the

@logmsg -1 "making progress" progress=0.5 

API.

@tpapp
Copy link
Author

tpapp commented Oct 23, 2018

I am making a PR right now using the @logmsg API.

@Roger-luo
Copy link
Contributor

I was wondering if we support conditional dependencies in Pkg would help. Like rust, users can choose enhancement like GPU, better Juno printing etc.while installing the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants