Create a WidgetTester extension to drag scroll bars (Resolves #22) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Simulates the user interacting with a Scrollbar. | ||
| extension ScrollbarInteractions on WidgetTester { | ||
| /// Press a scrollbar thumb at [thumbLocation] and drag it vertically by [delta] pixels. | ||
| Future<void> dragScrollbar(Offset thumbLocation, double delta) async { |
There was a problem hiding this comment.
How does the user know where there scrollbar thumb is located?
Also, we should use this in a test in this package to demonstrate that it works, and show how we expect others to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a WidgetTester extension to drag scroll bars. Resolves #22
Dragging a scrollbar requires hovering over the scroll bar, waiting for it to appear, and then dragging and releasing it.
This PR adds a
dragScrollbarmethod yo make it easier to interacting with a scrollbar.We can't use a finder to locate the scrollbar thumb because the scrollbar widget uses a single painter to paint both the scrollbar track and the thumb.
We have a
kTapMinTimeconstant in super_editor that we use in the tests. I needed to use the value directly here.