Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale filter does not correctly deserialize size property #4

Open
matthew-carroll opened this issue May 21, 2022 · 5 comments
Open

Scale filter does not correctly deserialize size property #4

matthew-carroll opened this issue May 21, 2022 · 5 comments
Labels
bounty_donation p2 Definitely want it, but timing isn't important

Comments

@matthew-carroll
Copy link
Collaborator

The ScaleFilter current serializes its size property using string interpolation, which sends "[Size]" to FFMPEG. Update the filter to serialize the appropriate string representation of a size to FFMPEG.
@abhay-s-rawat
Copy link

Working on it, I have fixed at my end, soon will send a pull request to owner.

@Thomasssb1
Copy link
Contributor

Fixed in my new PR #9

@Thomasssb1 Thomasssb1 mentioned this issue Jun 30, 2023
Merged
@matthew-carroll
Copy link
Collaborator Author

The referenced PR was merged, but I can't tell if this problem was solved. Re-visit this issue and see if it really is resolved.

@matthew-carroll matthew-carroll added bounty_donation p2 Definitely want it, but timing isn't important labels Jan 19, 2024
@Thomasssb1
Copy link
Contributor

Currently looking into this, but I am wondering what the use case is for VideoSize over just height and width? You mentioned you use it in your own project & would like to know so I can fix appropriately.

@matthew-carroll
Copy link
Collaborator Author

@Thomasssb1 I don't remember the context of this, but I'm guessing that I use VideoSize to pass around both a width and a height. Similar to the reason that we have Size in Flutter.

@Thomasssb1 Thomasssb1 mentioned this issue Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty_donation p2 Definitely want it, but timing isn't important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthew-carroll @abhay-s-rawat @Thomasssb1