Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't delete invalid recipient #2648

Closed
sosnovsky opened this issue Jan 7, 2025 · 2 comments · Fixed by #2650
Closed

Can't delete invalid recipient #2648

sosnovsky opened this issue Jan 7, 2025 · 2 comments · Fixed by #2650
Assignees
@ioanmo226
Labels
actionable bug
Milestone
1.3.2

Comments

@sosnovsky
Copy link
Collaborator

sosnovsky commented Jan 7, 2025 •
edited
Loading

  • enter some invalid recipient (like abc)
  • tap enter
  • app shows invalid recipient modal
  • click ok button in the modal
  • modal disappears and then appears again, so app is stuck in this state

there is a test for this case - https://github.com/FlowCrypt/flowcrypt-ios/blob/master/appium/tests/specs/mock/composeEmail/CheckInvalidEmailRecipient.spec.ts
@sosnovsky sosnovsky added this to the 1.3.2 milestone Jan 7, 2025
@sosnovsky
Copy link
Collaborator Author

Hi @ioanmo226, can you please work on this and #2649 issues, to prepare a new small release with these bugfixes, thanks!

@ioanmo226
Copy link
Collaborator

Okay

@ioanmo226 ioanmo226 mentioned this issue Jan 8, 2025
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Jan 20, 2025
@ioanmo226
#2648 fix: Invalid recipient delete issue (#2650)
3fc3a23 
* fix: invalid recipient delete issue

* temp: remove cache restore

* Revert "temp: remove cache restore"

This reverts commit 450347c.

* fix: emailjs-stringencoding

* temp: run failed tests

* fix: failed

* Revert "fix: failed"

This reverts commit 83eab1a.

* Revert "temp: run failed tests"

This reverts commit 909be3f.

* fix: ui test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioanmo226 ioanmo226

Labels
actionable bug
Projects
None yet
Milestone
1.3.2
Development

Successfully merging a pull request may close this issue.

#2648 fix: Invalid recipient delete issue FlowCrypt/flowcrypt-ios
2 participants
@sosnovsky @ioanmo226