Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2438 improve handling of invalid keys on message compose #2458

Merged

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Nov 30, 2023

This PR improved handling of invalid keys on message compose(Refresh EKM keys for invalid keys on message screen)

close #2438 // if this PR closes an issue


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226
Copy link
Collaborator Author

@sosnovsky Could you check in your local if below semaphoreci issue also occurs in your local?
It works fine in my local though. Only semaphoreci.

2023-12-01T05:55:10.621Z ERROR @wdio/config:ConfigParser: Failed loading configuration file: file:///Users/semaphore/git/flowcrypt-ios/appium/config/wdio.mock.conf.ts: Cannot use import statement outside a module
/Users/semaphore/git/flowcrypt-ios/appium/config/wdio.mock.conf.ts:100:05
import { join } from 'path';

@sosnovsky
Copy link
Collaborator

@sosnovsky Could you check in your local if below semaphoreci issue also occurs in your local? It works fine in my local though. Only semaphoreci.

Works well locally for me too.
Semaphore issue can be caused by different node.js version there, maybe they changed it recently, so setting node version explicitly in semaphore.yml should fix this issue.

@ioanmo226
Copy link
Collaborator Author

I think we set to correct node v18 in semaphoreci?

- sem-version node 18 && cache restore appium-npm && cd ./appium && npm i && cd .. && cache store appium-npm appium/node_modules

@sosnovsky
Copy link
Collaborator

I think we set to correct node v18 in semaphoreci?

I checked your previous PR (where tests were passing) and Semaphore used node 18.18.2 there, while this PR uses node 18.19.0, so looks like there is some changes in this node update which broke tests code.

You can try to use node v20 on semaphore, to check if it fixes issue.

@ioanmo226
Copy link
Collaborator Author

Yep!
Seems like v18.19.0 is not stable and when I change it to v20, it works fine.

@ioanmo226
Copy link
Collaborator Author

Thank you for your assistant

@ioanmo226 ioanmo226 marked this pull request as ready for review December 1, 2023 13:01
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner December 1, 2023 13:01
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, thanks!

@sosnovsky sosnovsky merged commit 4b3e6d8 into master Dec 1, 2023
5 checks passed
@sosnovsky sosnovsky deleted the 2438-improve-handling-of-invalid-keys-on-message-compose branch December 1, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve handling of invalid keys on message compose
2 participants