-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2438 improve handling of invalid keys on message compose #2458
#2438 improve handling of invalid keys on message compose #2458
Conversation
@sosnovsky Could you check in your local if below semaphoreci issue also occurs in your local?
|
This reverts commit 7b02e4a.
Works well locally for me too. |
I think we set to correct node v18 in semaphoreci? flowcrypt-ios/.semaphore/semaphore.yml Line 81 in 6fd5696
|
I checked your previous PR (where tests were passing) and Semaphore used node 18.18.2 there, while this PR uses node 18.19.0, so looks like there is some changes in this node update which broke tests code. You can try to use node v20 on semaphore, to check if it fixes issue. |
Yep! |
Thank you for your assistant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, thanks!
This PR improved handling of invalid keys on message compose(Refresh EKM keys for invalid keys on message screen)
close #2438 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):