Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shared-tenant-fes for reporting errors #2188

Open
tomholub opened this issue Apr 20, 2023 · 3 comments
Open

add shared-tenant-fes for reporting errors #2188

tomholub opened this issue Apr 20, 2023 · 3 comments
Milestone

Comments

@tomholub
Copy link
Collaborator

https://flowcrypt.com/api/help/error should be replaced with https://flowcrypt.com/shared-tenant-fes/api/v1/log-collector/exception

The new API has the following expected JSON input format:

    val name: String, // Exception name
    val message: String, // Exception message
    val url: String, // Error url
    val line: Long, // Error line
    val col: Long, // Error line col
    val line: Int, // Error line
    val col: Int, // Error line col
rohit1729 marked this conversation as resolved.
    val trace: String, // Stack trace text
    val version: String, // flowcrypt version
    val environment: String, // prod/dev/unknown
    val product: String, // web-ext/android/ios/web/web-portal
    val buildType: String, // consumer/enterprise

The API will be live with FES release 2023-07 later this month.

@tomholub tomholub added this to the 1.2.5: Maintenance milestone Apr 20, 2023
@sosnovsky
Copy link
Collaborator

@tomholub currently we're not reporting client errors from iOS app, they're collected only in App Store Connect.
So we'll need to implement this functionality from scratch

@tomholub
Copy link
Collaborator Author

I see. That can wait for now. The intention was to be able to shut down the old api.

@sosnovsky
Copy link
Collaborator

iOS app doesn't use any /api endpoints, so no changes currently needed:
https://github.com/FlowCrypt/flowcrypt-ios/blob/master/FlowCrypt/Functionality/Api/Account%20Server%20Apis/BackendApi.swift

@tomholub tomholub changed the title use shared-tenant-fes for reporting errors add shared-tenant-fes for reporting errors Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants