Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attachment details disappear when preview and back #1713

Open
tomholub opened this issue Jun 21, 2022 · 7 comments
Open

attachment details disappear when preview and back #1713

tomholub opened this issue Jun 21, 2022 · 7 comments
Assignees

Comments

@tomholub
Copy link
Collaborator

Same device as the linked issue.

Reproduce:

  1. go to Contacts app on Android, "manage", "export all". It produces a vcf file, like contacts.vcf
  2. use FlowCrypt for Android to send it to yourself encrypted
  3. open on iOS and notice the attachment on the bottom
  4. the contents of the file render as text in the "view attachment" screen
  5. tap the back icon on top left
  6. message shows but it's now missing attachment details

Originally posted by @tomholub in #1707 (comment)

@tomholub
Copy link
Collaborator Author

image

@ioanmo226
Copy link
Collaborator

I can't reproduce this issue either.
@sosnovsky Could you check if it happens in your side?

@sosnovsky
Copy link
Collaborator

I can't reproduce this issue either.
@sosnovsky Could you check if it happens in your side?

Yes, I'll try to reproduce it on my device. Maybe it depends on file name (so only long names disappear)?

@sosnovsky
Copy link
Collaborator

@ioanmo226 I wasn't able to reproduce this bug, but maybe it happens because of this line https://github.com/FlowCrypt/flowcrypt-ios/blob/master/Core/source/mobile-interface/endpoints.ts#L269, so Core fails to decrypt file name and UI shows empty string.

@ioanmo226
Copy link
Collaborator

Yeah, I agree.
But I wonder why it only happens after user goes back to screen.

Need more details from @tomholub though.

@sosnovsky
Copy link
Collaborator

But I wonder why it only happens after user goes back to screen.

App shows encrypted file name when user opens thread details screen for the first time.
Then user taps on attachment, app decrypts it and shows attachment details screen.
When user goes back app shows decrypted file name (which is empty), that's why attachment name is visible only before decryption.

@ioanmo226
Copy link
Collaborator

Oh. yes. Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants