Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning for incorrect PGP checksum #5868

Closed
ioanmo226 opened this issue Nov 22, 2024 · 3 comments · Fixed by #5883
Closed

Display warning for incorrect PGP checksum #5868

ioanmo226 opened this issue Nov 22, 2024 · 3 comments · Fixed by #5883
Assignees
@ioanmo226
Labels
actionable
Milestone
8.5.9

Comments

@ioanmo226
Copy link
Collaborator 

          Got it, then let's stick with the newest spec and update test to expect decrypted message text.

By the way, is there any possibility to find if message has incorrect checksum?
Then we at least be able to show some warning about checksum issue

Originally posted by @sosnovsky in #5866 (comment)
@sosnovsky sosnovsky added this to the 8.5.9 milestone Nov 22, 2024
@ioanmo226
Copy link
Collaborator Author

Maybe the warning message should be like below?

Warning: Checksum mismatch detected. This indicates the message may have been altered or corrupted during transmission. Decryption may still succeed, but verify the message source and integrity if possible.

@sosnovsky
Copy link
Collaborator

Sounds good 👍 Let's use it

@ioanmo226
Copy link
Collaborator Author

@sosnovsky This is the only remaining task assigned to me in the current milestone. (Other assigned tasks are in a later milestone or awaiting reproduction.)
Could you please review and assign new tasks?

@ioanmo226 ioanmo226 mentioned this issue Dec 20, 2024
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Dec 24, 2024
@ioanmo226
#5868 Display warning for incorrect pgp checksum (#5883)
fbb5a07 
* feat: display warning for incorrect pgp checksum

* fix: ui test

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioanmo226 ioanmo226

Labels
actionable
Projects
None yet
Milestone
8.5.9
Development

Successfully merging a pull request may close this issue.

#5868 Display warning for incorrect pgp checksum FlowCrypt/flowcrypt-browser
2 participants
@sosnovsky @ioanmo226