Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor content scripts to make it easier to implement Thunderbird support #5747

Closed
Tracked by #5670
tomholub opened this issue May 28, 2024 · 3 comments · Fixed by #5748
Closed
Tracked by #5670

refactor content scripts to make it easier to implement Thunderbird support #5747

tomholub opened this issue May 28, 2024 · 3 comments · Fixed by #5748
Assignees
Milestone

Comments

@tomholub
Copy link
Collaborator

One thing I noticed is that the content_scripts/webmail folder already on master is quite disorganised and not so easy to work on to add Thunderbird (or any other webmail) support. I country try and refactor it a little bit myself, and that could make it easier for you.

Originally posted by @tomholub in #5690 (comment)

@tomholub tomholub added this to the First priority milestone May 28, 2024
@tomholub tomholub self-assigned this May 28, 2024
@tomholub
Copy link
Collaborator Author

Additionally, there used to be automatic code style changes on save (for example ordering of private/public methods). Was it disabled, does it work for anyone else?

tomholub added a commit that referenced this issue May 29, 2024
* issue 5747 initial refactor

* removed dated comment

* cleanup

* added a generic folder

* remove unused notifyMurdered parameter

* added comment

* upload debug artifacts

* remove verbose google-mock listening logs
@sosnovsky
Copy link
Collaborator

Additionally, there used to be automatic code style changes on save (for example ordering of private/public methods). Was it disabled, does it work for anyone else?

private/public members ordering were auto-fixable in TSLint, but it needs to be manually fixed in ESLint.
Other common code styles issues are still automatically fixed on save.

@tomholub
Copy link
Collaborator Author

Got it 👌

@tomholub tomholub modified the milestones: First priority, 8.5.6 May 29, 2024
ioanmo226 pushed a commit that referenced this issue Jun 3, 2024
* issue 5747 initial refactor

* removed dated comment

* cleanup

* added a generic folder

* remove unused notifyMurdered parameter

* added comment

* upload debug artifacts

* remove verbose google-mock listening logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants