Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report "400 when POST-ing https://flowcrypt.com/attester/welcome-message" error #5741

Closed
sosnovsky opened this issue May 27, 2024 · 1 comment · Fixed by #5744
Closed
Assignees
Milestone

Comments

@sosnovsky
Copy link
Collaborator

We already have code for skipping this error - #5284, but these errors are reported again after manifest v3:

Bad Request: 400 when POST-ing https://flowcrypt.com/attester/welcome-message string: email,pubkey -> This key does not appear valid(Error: Could not find valid self-signature in key b4a63b803788e67e)

Maybe error text has changed and it's different from value in IGNORE_ERR_MSG array.

@sosnovsky sosnovsky added this to the 8.5.6 milestone May 27, 2024
@martgil martgil self-assigned this May 27, 2024
@martgil
Copy link
Collaborator

martgil commented May 28, 2024

Upon checking, the error message we are checking is way too vast and so some other issue's that occurs on the /attester/welcome-message may still reports other issues.

image

So I think a way to solve this is to adjust the matching pattern regardless of the error text next to Bad Request: 400 when POST-ing https://flowcrypt.com/attester/welcome-message string: email,pubkey ->.

sosnovsky pushed a commit that referenced this issue Jun 3, 2024
… endpoint (#5744)

* Refactor IGNORE_ERR_MSG for pattern matching on welcome-message endpoint

* Adjust pattern matching for IGNORE_ERR_MSG

---------

Co-authored-by: martgil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants