Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group similar error reports #5736

Closed
sosnovsky opened this issue May 24, 2024 · 5 comments · Fixed by #5750
Closed

Group similar error reports #5736

sosnovsky opened this issue May 24, 2024 · 5 comments · Fixed by #5750
Assignees
Milestone

Comments

@sosnovsky
Copy link
Collaborator

sosnovsky commented May 24, 2024

There are many error reports which are sent in doSendErrorToSharedTenantFes with similar message like 429 when GET-ing https://www.googleapis.com/gmail/v1/users/me/threads/18fa6109b0f0d121 (no body), which has the only difference - thread id.

For such cases we should just replace such parameters with THREAD_ID, so similar reports will be grouped on our backend.

@sosnovsky sosnovsky added this to the 8.5.6 milestone May 24, 2024
@sosnovsky
Copy link
Collaborator Author

the same happens for different extension ids, as example:

  • chrome-extension://mimchhddcelobciniokjnakmkcbdggof/chrome/elements/compose.htm
  • chrome-extension://pjohdcpiapjhagmakkjpgjmodmgfmkkd/chrome/elements/compose.htm

here we can replace extension ids with EXTENSION_ID

@sosnovsky
Copy link
Collaborator Author

Hi @ioanmo226, can you please work on this one before #5749, so it can be included in the 8.5.6 release to better distinguish client error reports. Thanks!

@ioanmo226
Copy link
Collaborator

Ok, got it

@ioanmo226
Copy link
Collaborator

Let me confirm
Do I have to replace those EXTENSION_ID and THREAD_ID in url field or trace field?
Or both?
image

@sosnovsky
Copy link
Collaborator Author

They should be changed in url and message fields, here is screenshot from error reports dashboard:

Screenshot 2024-05-31 at 11 45 00

Currently I noticed 3 paths which should be replaced (maybe in the future there will be another ones):

  • https://www.googleapis.com/gmail/v1/users/me/threads/18fa6109b0f0d121 -> https://www.googleapis.com/gmail/v1/users/me/threads/THREAD_ID
  • https://www.googleapis.com/gmail/v1/users/me/messages/16deefad688886d1 -> https://www.googleapis.com/gmail/v1/users/me/messages/MESSAGE_ID
  • chrome-extension://mimchhddcelobciniokjnakmkcbdggof/chrome/elements/compose.htm -> chrome-extension://EXTENSION_ID/chrome/elements/compose.htm (here I think we can just replace all chrome-extension://some_extension_id_aksdnasoinfas/... occurrences with chrome-extension://EXTENSION_ID/...

sosnovsky pushed a commit that referenced this issue May 31, 2024
* feat: group similar error reports

* fix: remove unnecessary line

* fix: simplify code

* fix: pr reviews
ioanmo226 added a commit that referenced this issue Jun 3, 2024
* feat: group similar error reports

* fix: remove unnecessary line

* fix: simplify code

* fix: pr reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants