Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5681 Replace OSSAR with ESLint workflow #5735

Merged
merged 38 commits into from
May 27, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented May 24, 2024

This PR replaces OSSAR GitHub action with ESLint with the goal of running straight-forward ESLint test.

close #5681


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner May 24, 2024 06:41
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
.github/workflows/eslint.yml Show resolved Hide resolved
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
@martgil martgil marked this pull request as draft May 24, 2024 08:58
@martgil
Copy link
Collaborator Author

martgil commented May 24, 2024

Thanks Roma - I'll check each comments and the apply necessary changes.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@martgil martgil marked this pull request as ready for review May 26, 2024 06:48
@martgil martgil requested a review from sosnovsky May 26, 2024 06:48
@martgil
Copy link
Collaborator Author

martgil commented May 26, 2024

Hi @sosnovsky this one is ready for review. thank you!

@martgil
Copy link
Collaborator Author

martgil commented May 26, 2024

By the way, Roma - do you know of any better and pleasing way to performing debugging in general. I don't like to my PRs populated with this commits info so I'd like to find a way to minize them as much as possible. Thank you for your advice!

.github/workflows/eslint.yml Outdated Show resolved Hide resolved
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
.github/workflows/eslint.yml Outdated Show resolved Hide resolved
@martgil martgil marked this pull request as draft May 27, 2024 12:49
@martgil martgil requested a review from sosnovsky May 27, 2024 13:14
@martgil martgil marked this pull request as ready for review May 27, 2024 13:14
@martgil
Copy link
Collaborator Author

martgil commented May 27, 2024

@sosnovsky Thank you for your help. I did my best to fix it, but you found a better way. I believe this one is ready to merge.

@sosnovsky
Copy link
Collaborator

By the way, Roma - do you know of any better and pleasing way to performing debugging in general. I don't like to my PRs populated with this commits info so I'd like to find a way to minize them as much as possible. Thank you for your advice!

Hi @martgil, do you mean debugging of github actions? You can run the same commands locally, but some steps will still require pushing commits to github for testing how it works in remote environment.

As for me, there is no issue with a large number of commits, as on the merge it'll still be just 1 commit.

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now 👍

@sosnovsky sosnovsky enabled auto-merge (squash) May 27, 2024 17:50
@sosnovsky sosnovsky merged commit 4252b8b into master May 27, 2024
12 of 13 checks passed
@sosnovsky sosnovsky deleted the issue-5681-replace-ossar-with-eslint-workflow branch May 27, 2024 18:14
@martgil
Copy link
Collaborator Author

martgil commented May 28, 2024

but some steps will still require pushing commits to github for testing how it works in remote environment.

Thank you, Roma, for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing OSSAR static analysis reporting
2 participants