Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5730 Fix error when sending blank signed message #5732

Merged
merged 2 commits into from
May 24, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented May 23, 2024

This PR improves the case where sending an empty signed message using FlowCrypt returns unhandled error. This is due to createCleartextMessage() not accepting empty message. So passing a newline that would serve as empty message would satify the condition when user choose to send blank signed email when asked by the FlowCrypt browser extension.

close #5730


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner May 23, 2024 12:40
@martgil
Copy link
Collaborator Author

martgil commented May 23, 2024

Hi @sosnovsky, I think this particular one does not need to test for such a small changes. Would you agree on that or should I make another test for sending blank signed message?

@martgil martgil requested a review from sosnovsky May 24, 2024 08:57
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit 034b77a into master May 24, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5730-fix-sending-blank-signed-message branch May 24, 2024 09:32
ioanmo226 pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to send empty signed-only message
2 participants