-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConfiguredIdpOAuth should produce an oauth window + save JWT to storage #5444
Comments
@sosnovsky , @tomholub For which domain, Custom IDP is configured? |
I was gonna work this one but i don't know which domain was configured to use custom IDP. |
We currently don't have configured custom IdP, here we just need code skeleton to support this functionality in the future. Mart started working on implementing custom IdP support (subtasks of #5311) and now we need to finalize remaining parts. For testing you can configure some IdP (like https://www.okta.com) and then check that authentication process will show 2 popups - first for Gmail permissions and second one for IdP authentication (in case when user has custom |
Ioan, We could configure an app on Auth0 or Okta and then you could include the configuration details from the IdP in the mock api - it will get returned from the mock FES. Then you can start the extension that uses the mock - not as a test, but for regular use. Just start the mock separately, then find the extension that was built for mock and load that into the browser. That will let you test thoroughly. Then for writing a test, you can configure the mock fes to send configuration that is pointing to mock idp, which we already have. Just with some slightly different parameter in the url, which will make the mock idp render slightly different ui, which you will start checking for during the test. (every time the tests go through idp ui, you'll either check that it's the mock of "normal" idp, or "custom" idp, based on what you were expecting to see) |
…torage (#5795) * WIP: add custom idp implementation * WIP: added ui test * fix: ui test * fix: refactor * fix: typo * fix: test client id * fix: pr reviews * fix: pr reviews * feat: use chrome.identity.launchWebAuthFlow and updated UI test
part of #5311
The text was updated successfully, but these errors were encountered: