Hide the quoted email when display a reply

[DenBond7]

          I also noticed that for every reply ever received in the thread conversation view, the quoted email is permanently shown, whether it is an indented blockquote or uses ">" for the quoted email.

Meanwhile, Gmail and the FlowCrypt browser extension hide the previous conversations/quoted emails and provide a triple-dot icon button that, when clicked, reveals the previous conversation. I just thought it might be something missing or an improvement for UX to help users focus on the important replies first.

Originally posted by @martgil in #2821 (comment)

[DenBond7]

@sosnovsky @ioanmo226

I've found how you parse quotes

https://github.com/FlowCrypt/flowcrypt-ios/blob/72cb26b61786a736f91f6dad2c0a42d655410237/FlowCrypt/Functionality/Mail%20Provider/Message%20Provider/ProcessedMessage.swift#L132

Could you tell me how you hide/show quoted text? Do you use JavaScript?

[sosnovsky]

No, it's done natively - we toggle shouldShowQuote flag when user taps ... button.
And depending on shouldShowQuote value we show/hide quoteNode

https://github.com/FlowCrypt/flowcrypt-ios/blob/72cb26b61786a736f91f6dad2c0a42d655410237/FlowCryptUI/Cell%20Nodes/MessageTextSubjectNode.swift#L80

[DenBond7]

And depending on shouldShowQuote value we show/hide quoteNode

private let messageNode = ASEditableTextNode()
private let quoteNode = ASEditableTextNode()

messageNode or quoteNode - is it a view(part of UI, Sorry, I don't know the right terminology) that can show HTML?

You have a separate view to show base content and quoted text. Right?

[ioanmo226]

The messageNode and quoteNode are similar to TextView components, which display message content and quote content, respectively.
To show HTML content in iOS, we first convert the HTML to an NSAttributedString.
This NSAttributedString is then set as the content for both the messageNode and quoteNode.

When the user taps the toggleQuoteButtonNode, it triggers an action that toggles the visibility of the quoteNode.

[DenBond7]

One more question

On Android, we sanitize received content. We have the following

flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt

Line 128 in 8349855

private val ALLOWED_ELEMENTS = arrayOf(

flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt

Line 166 in 8349855

private val ALLOWED_ATTRS = mapOf(

flowcrypt-android/FlowCrypt/src/main/java/com/flowcrypt/email/security/pgp/PgpMsg.kt

Line 178 in 8349855

private val ALLOWED_PROTOCOLS = arrayOf(

Do you have something similar?

Why am I asking? I have to use WebView to show received content because we allow some tags that I can't show inside TextView. Just interesting what is permitted on iOS.

[ioanmo226]

We sanitize html in javascript side.

https://github.com/FlowCrypt/flowcrypt-ios/blob/72cb26b61786a736f91f6dad2c0a42d655410237/FlowCrypt/Functionality/Mail%20Provider/Message%20Provider/ProcessedMessage.swift#L118

https://github.com/FlowCrypt/flowcrypt-ios/blob/72cb26b61786a736f91f6dad2c0a42d655410237/Core/source/mobile-interface/endpoints.ts#L123

[DenBond7]

For me

https://stackoverflow.com/questions/10813581/can-i-replace-the-expand-icon-of-the-details-element
https://stackoverflow.com/questions/55031395/how-to-change-summary-text-if-details-has-open-attr
https://www.sitepoint.com/style-html-details-element/

[DenBond7]

@sosnovsky @ioanmo226 One more question. How do you identify quotes for encrypted messages?

[sosnovsky]

We have simple check for finding lines which start from On and end with wrote: - https://github.com/FlowCrypt/flowcrypt-ios/blob/72cb26b61786a736f91f6dad2c0a42d655410237/FlowCrypt/Functionality/Mail%20Provider/Message%20Provider/ProcessedMessage.swift#L160