Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield Modifiers #110

Open
1 of 5 tasks
Draycia opened this issue Aug 19, 2019 · 9 comments
Open
1 of 5 tasks

Shield Modifiers #110

Draycia opened this issue Aug 19, 2019 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Draycia
Copy link
Contributor

Draycia commented Aug 19, 2019

  • Apply blindness to people hit by the shield
  • Apply weakness to people hit by the shield
  • Apply slowness to people when hit by the shield
  • Apply nausea to people when hit by the shield
  • Optionally allow knockback on shields

I'm not sure if all servers would like having these enabled or how long / strong the effects should be (though both of those things should be configurable), but I don't see any harm in adding them anyway as they can be disabled.

@Draycia Draycia added enhancement New feature or request help wanted Extra attention is needed unsure May or may not be implemented / fixed labels Aug 19, 2019
@Flo56958
Copy link
Owner

Add the compatibility for the shield in off hand (so it can trigger modifier and exp)

@Draycia
Copy link
Contributor Author

Draycia commented Aug 19, 2019

Maybe these effects could optionally be incompatible (just like the protection modifiers) too.

@Flo56958
Copy link
Owner

I think except for Reinforced (unbreaking) and mending non of the vanilla enchantments work on the shield. (and need to be implemented by us?)

@Flo56958 Flo56958 added this to the Version 1.1 milestone Aug 19, 2019
@Draycia
Copy link
Contributor Author

Draycia commented Aug 19, 2019

Knockback works on all items in the game which is why I added it.
And unbreaking/mending work too yeah.

I'm not sure about any others though and I don't plan on testing if any work.

@Flo56958
Copy link
Owner

Flo56958 commented Aug 19, 2019

https://minecraft.gamepedia.com/Shield
So the wiki says only the two enchantments. (but for Knockback you need to punch with the shield... not really intuitive. Maybe we could add a feature to push mobs back when a melee attack was countered with the shield. And projectiles could bounce back?[from #81])

@Flo56958
Copy link
Owner

See #81 for more Modifier ideas for the shield

@Flo56958
Copy link
Owner

The effects from hitting the shield could be combined with some ideas in the other issue.

@Draycia
Copy link
Contributor Author

Draycia commented Aug 19, 2019

With the ideas in this issue I'm mainly thinking of people swapping with the F key (default for en_US layouts) and hitting things with their shields, then swapping back with F.

You can block with your shield in either hand (and can block with two shields if there's on in each hand) so I don't see it as too unintuitive. We could make descriptions something like "Bashing with shield applies weakness to the target."

@Draycia
Copy link
Contributor Author

Draycia commented Aug 19, 2019

It would be optimal if you could left click while blocking to "Shield Bash" but minecraft doesn't support that and I don't think there's a way to simulate it. Swapping and hitting would likely be the best compromise if there's no better ways to do it.

Alternatively, applies the effect(s) when hit while blocking?

@Draycia Draycia removed the unsure May or may not be implemented / fixed label Aug 20, 2019
@Flo56958 Flo56958 removed this from the Version 1.1 milestone Sep 4, 2019
@Flo56958 Flo56958 added this to the Version 1.4 milestone Oct 3, 2019
@Flo56958 Flo56958 removed this from the Version 1.4 milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants