Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Should give feedback when a language code fails #83

Open
ConfusedVorlon opened this issue Mar 1, 2023 · 2 comments
Open

[Feat] Should give feedback when a language code fails #83

ConfusedVorlon opened this issue Mar 1, 2023 · 2 comments
Assignees
Labels
Feature Request New functionality the app doesn't provide yet Size: Tiny Probably less than 1 day of work

Comments

@ConfusedVorlon
Copy link

Steps to Reproduce:

I set up some languages using folder codes copied from another app.
Amongst others, I used pt.lproj

Expected Behavior:

strings should translate - or give a useful message

Current Behavior:

translations fail silently
(using Microsoft translate)

Comment

I remembered an old bug where RemaFox crashed on the pt folder, looked at that, and realised I needed pt-PT
That's fine - but it would have been super helpful for RemaFox to tell me that it couldn't handle a particular lproj folder, and perhaps link me to a list of supported folder codes

(fwiw - iOS is perfectly happy with pt)

I hit similar issues with a few other languages, I didn't note them down :(

Environment

Show environment details
  • App Version: 1.4.1 (Build 63)
  • System Version: 13.2.1 (Build 22D68)
  • System CPU: Apple M1 Ultra
  • Tier: Pro
@Jeehut
Copy link
Member

Jeehut commented Mar 3, 2023

@ConfusedVorlon Thank you for reporting this. It totally makes sense to provide more detailed information when something fails so users can understand the problem better. It's true that not all languages you can potentially choose in Xcode are supported. And for some codes like pt there is some ambiguity involved and translation services support different versions (pt-PT and pt-BR) where I wouldn't know what to do with a language pt (should I choose Portugal, the originating country, or Brazil, the country with most speakers?), so I opted for the more clear ones. But especially for those cases that will commonly occurr, I should provide a better handling so users don't get confused. Will tackle soon!

@Jeehut Jeehut self-assigned this Mar 3, 2023
@Jeehut Jeehut added the Bug Report An unexpected behavior of existing functionality label Mar 3, 2023
@Jeehut
Copy link
Member

Jeehut commented Apr 14, 2023

@ConfusedVorlon I just checked this and I couldn't find any crash here, it seems the crash has already been fixed with a previous update. The only problem here seems to be that the translation skips languages it doesn't know about, which I don't really consider a bug. But I totally agree that there should be some kind of feedback for users about non-supported languages and maybe even a tip to use a different code if the language is basically supported, but under a different code.

I think I will solve this together with #71 sometime later.

@Jeehut Jeehut added Feature Request New functionality the app doesn't provide yet Size: Tiny Probably less than 1 day of work and removed Bug Report An unexpected behavior of existing functionality labels Apr 14, 2023
@Jeehut Jeehut changed the title [Bug] Should give feedback when a language code fails [Feat] Should give feedback when a language code fails Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New functionality the app doesn't provide yet Size: Tiny Probably less than 1 day of work
Projects
None yet
Development

No branches or pull requests

2 participants