convex/messages.ts (2)

289-289: ⚠️ Potential issue

Change type from string to Id<"messages">.

As per PR objectives and past review comments, the type for messageId should be changed from string to Id<"messages">.

Apply this diff:

-    messageId: v.string(),
+    messageId: v.id("messages"),

---

295-297: 🛠️ Refactor suggestion

Remove console.log in production.

Console.log statements should not be present in production code.

Apply this diff:

-      console.error("Unauthenticated call to mutation");
-      return null;
+      throw new ConvexError("Unauthenticated call to mutation");

src/components/forwardMessage.tsx (3)

73-73: Fix typo in dialog title.

There's a typo in the dialog title: "Fordward" should be "Forward".

Apply this diff:

-            <p className="mt-1">Fordward</p>{" "}
+            <p className="mt-1">Forward</p>{" "}

---

84-86: Enhance loading state UI.

The loading state could be improved to provide better user feedback.

Consider applying this diff for a more polished loading state:

-            <LoaderCircle className="mr-1.5 animate-spin justify-center p-0.5" />
+            <div className="flex flex-col items-center justify-center space-y-2">
+              <LoaderCircle className="h-8 w-8 animate-spin" />
+              <p className="text-sm text-muted-foreground">Loading chats...</p>
+            </div>

---

128-133: Simplify conditional className.

The conditional className logic can be simplified.

Apply this diff:

-                      className={cn(
-                        "mt-4 flex cursor-pointer rounded-xl bg-secondary p-5",
-                        user.username == userInfos[0]?.username
-                          ? "h-0 p-0"
-                          : null,
-                      )}
+                      className={cn("mt-4 flex cursor-pointer rounded-xl bg-secondary p-5", {
+                        "h-0 p-0": user.username == userInfos[0]?.username
+                      })}

convex/messages.ts (1)

314-324: Remove redundant message existence check.

The message existence check is redundant since getX will throw if the message doesn't exist.

Apply this diff:

-      const parsedMessageId = ctx.table("messages").normalizeId(args.messageId);
-
-      if (!parsedMessageId) {
-        throw new ConvexError("messageId was invalid");
-      }
-
-      const message = await ctx.table("messages").getX(parsedMessageId);
-
-      if (!message) {
-        throw new ConvexError("Message does not exist");
-      }
+      const message = await ctx.table("messages").getX(args.messageId);

src/components/message.tsx (2)

275-279: Follow React's naming convention for state variables.

The state variable and setter function should follow camelCase naming convention:

-const [ForwardedMessageId, setForwardedMessageId] = useQueryState(
+const [forwardedMessageId, setForwardedMessageId] = useQueryState(

---

281-283: Follow React's naming convention for event handlers.

The handler function should follow camelCase naming convention:

-const ForwardHandler = () => {
+const handleForward = () => {

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/components/message.tsx (1)

796-804: 🛠️ Refactor suggestion

Use button element for consistency and accessibility.

The forward action in the receiver's context menu should use a button element to match the sender's implementation and improve accessibility.

-<div
+<button
  onClick={() => {
    handleForward();
  }}
  className="flex w-full cursor-pointer border-b-2 border-secondary-foreground p-2 pr-8"
>
  <Forward />
  <p className="ml-1">Forward</p>
-</div>
+</button>

src/components/message.tsx (1)

275-279: Improve comment clarity and type safety.

The comment needs to be more professional and concise. Additionally, consider using a more type-safe approach.

  const [ForwardedMessageId, setForwardedMessageId] = useQueryState(
-    // It is used to show if the forward dialog should be shown. If the string is empty the dialog should be not shown if there is an id inside it should
+    // Controls the visibility of the forward dialog based on message ID presence
    "forward",
-    parseAsString.withDefault(""),
+    parseAsString.withDefault("") as Id<"messages"> | "",
  );

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro