Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache HTML suggestions / improve suggestion loading performance #39

Open
benbasson opened this issue Aug 25, 2014 · 0 comments
Open

Cache HTML suggestions / improve suggestion loading performance #39

benbasson opened this issue Aug 25, 2014 · 0 comments

Comments

@benbasson
Copy link
Member

We are currently rebuilding the HTML for the suggestions list every time it's updated, which means (at minimum):

  • sorting the list
  • creating the HTML for every suggestion
  • binding the event handlers for every suggestion
  • dealing with hierarchy / existing selected tags

It seems like there are some decent performance gains to be had here - we could definitely look at at least caching the objects in memory so that we can re-insert them to the DOM faster. Another option is always leaving all suggestions in the DOM, but manipulating which are shown / not shown / not selectable.

@benbasson benbasson changed the title Cache HTML suggestions Cache HTML suggestions / improve suggestion loading performance Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant