Added validation for the context of extensions #361
Conversation
# Conflicts: # src/Firely.Fhir.Validation/Impl/FhirPathValidator.cs # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases
|
We have an issue here (Apart from the fact that I seem to have done something weird with the subrepo). We do not step into every profile we encounter. This makes sense for some cases, except it makes verifying whether we are in the correct Element a lot harder, and as a bonus, I believe omitting it is a wrong assumption. In a separate branch, I created a Patient with a link (backboneElement) with multiple id's and, lo and behold, the validation is a success! I believe us not invoking the profile of backboneElement is a mistake here. This would require quite a big change to the validator though, but it would make my work a LOT easier. I will leave this branch for now until we have discussed this internally. |
# Conflicts: # test/Firely.Fhir.Validation.Compilation.Tests.Shared/FhirTestCases
…tension-Context.Resource
.idea/.idea.Firely.Validator.API/.idea/projectSettingsUpdater.xml
Outdated
Show resolved
Hide resolved
src/Firely.Fhir.Validation.Compilation.Shared/SchemaBuilders/ExtensionContextBuilder.cs
Show resolved
Hide resolved
src/Firely.Fhir.Validation.Compilation.Shared/SchemaBuilders/TypeReferenceBuilder.cs
Outdated
Show resolved
Hide resolved
| if (Contexts.Any(c => c.Type == null)) | ||
| { | ||
| return new IssueAssertion(Issue.PROFILE_ELEMENTDEF_INCORRECT, | ||
| "Extension context type was not set, but a context was defined. Skipping non-invariant context validation") |
There was a problem hiding this comment.
Shouldn't we report this in the constructor? Then we can catch it before we ship the validation to the client.
There was a problem hiding this comment.
We can still validate invariants. What should we do here?
…t was inconsistent. Also updated manifest.
Description
The validator should now (finally) validate extension contexts against their expected context.
Related issues
Closes #267
Tests
Added tests for all possible extension contexts