New Firely validator does not complain when extension is used outside of its context

[wardweistra]

Describe the bug
When validating a resource which uses an extension outside of its defined context, the new Firely validator does not report an error.

To Reproduce

1. Take an extension which has context defined as the element Address: https://simplifier.net/Signal-MSO-FHIR-Profiles/SignalRegion/~xml
2. Take a Location resource where an extension is used in the root: https://simplifier.net/snippet/wardweistra/66
3. Validate it with the new validator, eg with the Validation Demo tool
4. See that it reports SUCCESS without any errors or warnings

Expected behavior
Error that the extension is incorrectly used

Screenshots
See next comment

Version used:

• FHIR Version: R4
• Version: This commit of the validation demo: FirelyTeam/Firely.Fhir.ValidationDemo@a3a7051

Additional context
Slack Message

[wardweistra]

Confirmed with the Firely Validation Demo that it passes validation with warnings/errors.

[ewoutkramer]

I can confirm this blindly: We don't check the context at all - never implemented that!

[ewoutkramer]

BTW: We're trying to avoid having validator issues here. We will need to transfer this issue to the validator repo, but since this is a private repo (at this moment), I cannot use GitHub's transfer funtion yet, so have to do that when we open up the repo in january!

[mikaelweave]

@ewoutkramer - do you know if the old validator checked extension context? I'm working with a support issue on this very profile and am making sure I understand what's happening. Thank you! 😄

[alexzautke]

No, extension context checking was never implemented in the old validator.

[Narnian12]

@ewoutkramer do you happen to know when the new validator will be public? We want to start using profile validation within our code, and have been trying to use the legacy one, but figured it would be much better to use the more recent one.

[ewoutkramer]

This week - we're busy preparing the release!

[mikaelweave]

Thanks @alexzautke, appreciate the confirmation. Looks like we need to update to the new one. 😄

[mmsmits]

The new validator is available, I transferred the issue

[ewoutkramer]

No, extension context checking was never implemented in the old validator.

Just to manage expectations: It's not yet implemented in the new one either ;-)

We'll bump the priority now I know someone is waiting for it.

[mmsmits]

duplicate of #134

[mmsmits]

The context can be defined in three different ways:
http://hl7.org/fhir/valueset-extension-context-type.html

We have notion of the definition path to validate these contexts.