Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$process-message operation on FhirClient #2605

Closed
LodewijkSioen opened this issue Oct 13, 2023 · 5 comments · Fixed by #2634
Closed

$process-message operation on FhirClient #2605

LodewijkSioen opened this issue Oct 13, 2023 · 5 comments · Fixed by #2634

Comments

@LodewijkSioen
Copy link
Contributor

LodewijkSioen commented Oct 13, 2023

Is your feature request related to a problem? Please describe.
We're working with FHIR messaging. For this we opted to use the $process-message operation. This line in the specifications is giving me headaches:

This operation does not use the parameters resource; the parameters "async" and "response-url" always go in the URL, if they are used, and the "content" parameter is always the body of the HTTP message.

I don't think it is possible to do this with the FhirClient. All the operation-based functions take a Parameter object and post it to the server.
cf #2601

Describe the solution you'd like

public virtual Task<Bundle?> ProcessMessageAsync(Bundle bundle, bool async = false, string responseUrl = null, CancellationToken? ct = null)

Describe alternatives you've considered
Not using the FhirClient and do everything using the vanilla HttpClient :(

@LodewijkSioen
Copy link
Contributor Author

Would you accept a PR for this? If so, is there a process for this?

@LodewijkSioen
Copy link
Contributor Author

I went ahead and just did it ;)

@mmsmits
Copy link
Member

mmsmits commented Dec 5, 2023

Thanks @LodewijkSioen, this is greatly appreciated.
I'll take a look at this.

Sorry for not responding to your question earlier.

@LodewijkSioen
Copy link
Contributor Author

@mmsmits no problem. What is the release schedule for the SDK?

@mmsmits
Copy link
Member

mmsmits commented Dec 5, 2023

Normally, we release once every month or so, but I'm not sure we'll get one before Christmas.
In the mean time, you can always use a pre-release package. The package with your PR will appear here within 45 minutes or so. https://github.com/FirelyTeam/firely-net-sdk/pkgs/nuget/Hl7.Fhir.R4/versions

Note: this can also contain other changes, they are a representation of the current develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants