Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix row grid so f-*_not-* doesn't count as last child in a row #111

Open
dotnetCarpenter opened this issue May 14, 2016 · 0 comments
Open
Assignees
Milestone

Comments

@dotnetCarpenter
Copy link
Member

The last element (we're using last-child) in a row doesn't have a margin-right for the gutter. We have classes like f-row_not-desktop/f-row__not-desktop that hides a cell or row in a viewport width. Using our current logic, they still count as elements when using last-child, hence the visual last-child still has a margin-right gutter.

The workaround is to make the last cell take up -1 space out of the grid. The problem is that the workaround possibly makes the alignment wrong. And is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant