Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an icon font #48

Open
nt1m opened this issue Oct 23, 2017 · 5 comments
Open

Provide an icon font #48

nt1m opened this issue Oct 23, 2017 · 5 comments
Labels

Comments

@nt1m
Copy link
Collaborator

nt1m commented Oct 23, 2017

It's handy for the web if we could generate an icon font from the SVGs.

There are some tools to do that, like fontello: http://fontello.com/

@nt1m
Copy link
Collaborator Author

nt1m commented Oct 23, 2017

The challenges this repo have to create an icon font are

  • there are duplicate icons (themes and customize for example)
  • the size suffix in the file names (-16, -12, ...) will cause the generated CSS to also include the suffix

@aminalhazwani
Copy link
Collaborator

aminalhazwani commented Oct 23, 2017

I am not really sure about icons font, they bring a lot of drawbacks to the table, I can provide more details but this talk is a very good summary https://speakerdeck.com/ninjanails/death-to-icon-fonts

@brassy-
Copy link
Collaborator

brassy- commented May 25, 2018

What @aminalhazwani said. @nt1m I'd like to close this issue if it's ok for you.

@nt1m
Copy link
Collaborator Author

nt1m commented May 26, 2018

@brassy- @aminalhazwani I agree with a lot of arguments on the slides, but where the icon fonts really win over inline SVG is webpage performance (creating SVG markup costs).

I don't think it's extremely essential though.

@aminalhazwani
Copy link
Collaborator

Hey @nt1m feel free to give it a take on the /photon-icons repo https://github.com/FirefoxUX/photon-icons 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants