Skip to content

Fix FBProcedureCall.checkParameters() #775

Closed as not planned
Closed as not planned
@mrotteveel

Description

@mrotteveel

Currently, the method FBProcedureCall.checkParameters() doesn't actually do what it claims to do (checking if all parameters are set). The most obvious example of this is that FBEscapedParser.convertProcedureCall calls it, and that means it would fail if it was parsing a call-escape with parameters, and currently it succeeds without error.

We need to investigate what the method should do on each call site, and correct the method and/or replace it with a new method that does the right thing for that call site.

In fact, the way procedure parameters are currently handled in FBProcedureCall seems odd at best, so this might need a deeper dive.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions