Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FBProcedureCall.checkParameters() #775

Closed
mrotteveel opened this issue Oct 28, 2023 · 1 comment
Closed

Fix FBProcedureCall.checkParameters() #775

mrotteveel opened this issue Oct 28, 2023 · 1 comment

Comments

@mrotteveel
Copy link
Member

Currently, the method FBProcedureCall.checkParameters() doesn't actually do what it claims to do (checking if all parameters are set). The most obvious example of this is that FBEscapedParser.convertProcedureCall calls it, and that means it would fail if it was parsing a call-escape with parameters, and currently it succeeds without error.

We need to investigate what the method should do on each call site, and correct the method and/or replace it with a new method that does the right thing for that call site.

In fact, the way procedure parameters are currently handled in FBProcedureCall seems odd at best, so this might need a deeper dive.

@mrotteveel
Copy link
Member Author

I have come to the conclusion that this needs to be done as part of #343. Unfortunately, that issue keeps slipping because of its complexity and my indecision regarding an approach to take.

@mrotteveel mrotteveel removed this from the v6-initial milestone Nov 5, 2024
@mrotteveel mrotteveel closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant