Skip to content

Wrong memory buffer alignment and IO buffer size when working in direct IO mode #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hvlad opened this issue Nov 25, 2023 · 2 comments · Fixed by #7890
Closed

Wrong memory buffer alignment and IO buffer size when working in direct IO mode #7873

hvlad opened this issue Nov 25, 2023 · 2 comments · Fixed by #7890
Assignees
@hvlad
Labels
affect-version: 3.0.0 affect-version: 4.0.0 affect-version: 5.0 Initial affect-version: 6.0 Initial fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 qa: cannot be tested type: bug

Comments

@hvlad
Copy link
Member

hvlad commented Nov 25, 2023

Customer reports that nbackup issues error when backup database:

IO error reading file: database.fdb
The parameter is incorrect.

Investigation shows that:

  1. The OS is Windows,
  2. error happens with direct IO ON only (switch -D ON),
  3. volume where database file reside have following properties (I show important ones only):

Bytes Per Sector : 4096
Bytes Per Physical Sector : 4096
@hvlad hvlad self-assigned this Nov 25, 2023
hvlad added a commit that referenced this issue Nov 25, 2023
@hvlad
Fixed bug #7873 : IO error reading file, The parameter is incorrect.
f8571de
@hvlad hvlad linked a pull request Nov 25, 2023 that will close this issue
Fixed bug #7873 : IO error reading file, The parameter is incorrect. #7874
Closed
@hvlad hvlad mentioned this issue Nov 25, 2023
Closed
@hvlad hvlad changed the title IO error reading file, The parameter is incorrect. Wrong memory buffer alignment and IO buffer size when working in direct IO mode Nov 29, 2023
hvlad added a commit that referenced this issue Nov 29, 2023
@hvlad
Fixed bug #7873 : Wrong memory buffer alignment and IO buffer size wh…
f8db151 
…en working in direct IO mode
@hvlad hvlad linked a pull request Nov 29, 2023 that will close this issue
Fixed bug #7873 : Wrong memory buffer alignment and IO buffer size when working in direct IO mode #7890
Merged
hvlad added a commit that referenced this issue Dec 21, 2023
@hvlad
Fixed bug #7873 : Wrong memory buffer alignment and IO buffer size wh…
cc62922 
…en working in direct IO mode (#7890)

* Fixed bug #7873 : Wrong memory buffer alignment and IO buffer size when working in direct IO mode

* Use alignas() per Adriano suggestion

* Remove unused variable
@hvlad
Copy link
Member Author

hvlad commented Dec 21, 2023

Re-opened for backporting

@hvlad hvlad reopened this Dec 21, 2023
hvlad added a commit that referenced this issue Dec 21, 2023
@hvlad
Fixed bug #7873 : Wrong memory buffer alignment and IO buffer size wh…
7db9ee6 
…en working in direct IO mode (#7890)
@hvlad
Copy link
Member Author

hvlad commented Dec 21, 2023

Will be ported into v5 later

hvlad added a commit that referenced this issue Jan 12, 2024
@hvlad
Fixed bug #7873 : Wrong memory buffer alignment and IO buffer size wh…
b90c02f 
…en working in direct IO mode (#7890)
@hvlad hvlad closed this as completed Jan 12, 2024
hvlad added a commit that referenced this issue Oct 14, 2024
@hvlad
Restore zero-initialization of just allocated buffers, that was lost …
ff1f47d 
…with fix for #7873, unfortunately.
hvlad added a commit that referenced this issue Oct 14, 2024
@hvlad
Restore zero-initialization of just allocated buffers, that was lost …
9b1e09c 
…with fix for #7873, unfortunately.
hvlad added a commit that referenced this issue Oct 14, 2024
@hvlad
Restore zero-initialization of just allocated buffers, that was lost …
d7e73b7 
…with fix for #7873, unfortunately.
@dyemanov dyemanov mentioned this issue Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
affect-version: 3.0.0 affect-version: 4.0.0 affect-version: 5.0 Initial affect-version: 6.0 Initial fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 qa: cannot be tested type: bug
Projects
None yet
Milestone
No milestone
2 participants
@hvlad @pavel-zotov