Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: FirebaseExtended/firebase-queue
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.1
Choose a base ref
...
head repository: FirebaseExtended/firebase-queue
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Apr 18, 2016

  1. 2
    Copy the full SHA
    845a664 View commit details

Commits on May 22, 2016

  1. Copy the full SHA
    76413e5 View commit details
  2. Copy the full SHA
    87cb70d View commit details
  3. Copy the full SHA
    13a2e57 View commit details

Commits on May 27, 2016

  1. Added GitHub templates and rearranged README (#68)

    Jacob Wenger authored and Chris Raynor committed May 27, 2016
    Copy the full SHA
    f5e3c38 View commit details
  2. Removing dead link (#69)

    Chris Raynor committed May 27, 2016
    Copy the full SHA
    f9915c9 View commit details

Commits on Jul 23, 2016

  1. [Feature] Add/Remove workers dynamically. (#72)

    Chris Raynor authored Jul 23, 2016
    1
    Copy the full SHA
    fa309f0 View commit details
  2. Copy the full SHA
    d356434 View commit details
  3. Copy the full SHA
    21ac46f View commit details

Commits on Aug 30, 2016

  1. Update guide.md (#78)

    Chris Raynor authored Aug 30, 2016
    Copy the full SHA
    66f7a5c View commit details
  2. in_progress_state confusion (#77)

    Hi there,
    
    Our team was tracking down a bug due to us defining the same `in_progress_state` name on all our workers. We did not understand what it did, but after a great explanation here: #76, we suggest to open the docs to be more explicit about how this actually works :)
    
    Thanks for a really amazing project, this has totally saved our startup!
    christianalfoni authored and Chris Raynor committed Aug 30, 2016
    Copy the full SHA
    f7c853e View commit details

Commits on Nov 4, 2016

  1. Clarifying the documentation around numWorkers not spawning child pro…

    …cesses
    Chris Raynor committed Nov 4, 2016
    Copy the full SHA
    460cc20 View commit details

Commits on Nov 14, 2016

  1. Clarifying the documentation around numWorkers not spawning child pro…

    …cesses (#88)
    Chris Raynor authored Nov 14, 2016
    Copy the full SHA
    b3bbc73 View commit details

Commits on Nov 23, 2016

  1. Copy the full SHA
    5d2954e View commit details
  2. Merge pull request #92 from firebase/uuid

    chore(package): update uuid to version 3.0.0
    Chris Raynor authored Nov 23, 2016
    Copy the full SHA
    06646e0 View commit details
  3. Updating the test suite to use firebase-admin (#93)

    * Updating dependencies and removing direct firebase dependency from code
    
    * Updating the docs to mention you can use either a firebase-admin or firebase database ref
    Chris Raynor authored Nov 23, 2016
    Copy the full SHA
    16217dc View commit details

Commits on Nov 24, 2016

  1. v1.6.0 changelog (#94)

    Chris Raynor authored Nov 24, 2016
    Copy the full SHA
    d8f88b6 View commit details
  2. Copy the full SHA
    8e2d211 View commit details
  3. Copy the full SHA
    83fba00 View commit details

Commits on Dec 20, 2016

  1. Copy the full SHA
    b8f259d View commit details
  2. Changelog for release (#97)

    Chris Raynor authored Dec 20, 2016
    Copy the full SHA
    90d7a9e View commit details
  3. Copy the full SHA
    4ffbdf2 View commit details
  4. Copy the full SHA
    7df13b6 View commit details

Commits on Jan 5, 2017

  1. Add retries field to suggested specs rules (#100)

    The `retries` field of the specs was missing from the suggested rules. Together with `$other": {  ".validate": false }` this meant that the retries parameter could not be used in specs.
    Chris Raynor authored Jan 5, 2017
    Copy the full SHA
    fbaad3d View commit details

Commits on Feb 22, 2017

  1. Added version number to package.json (#111)

    ### Description
    
    Catapult (the internal tool we use to release Firebase JavaScript libraries) now works without the `0.0.0` version placeholder in the `package.json` file. So, we can finally add the actual version numbers back into this file.
    
    ### Code sample
    
    N/A
    Jacob Wenger authored Feb 22, 2017
    Copy the full SHA
    c8f6873 View commit details

Commits on Mar 10, 2017

  1. Copy the full SHA
    24b7cb0 View commit details

Commits on Aug 6, 2020

  1. Add disclaimer (#121)

    samtstern authored Aug 6, 2020
    Copy the full SHA
    bd639b6 View commit details
Showing with 1,123 additions and 1,546 deletions.
  1. +103 −0 .github/CONTRIBUTING.md
  2. +56 −0 .github/ISSUE_TEMPLATE.md
  3. +31 −0 .github/PULL_REQUEST_TEMPLATE.md
  4. +2 −0 .gitignore
  5. +7 −3 .travis.yml
  6. +28 −485 README.md
  7. +0 −1 changelog.txt
  8. +0 −754 dist/lib/queue_worker.js
  9. +0 −205 dist/queue.js
  10. +555 −0 docs/guide.md
  11. +13 −26 package.json
  12. +65 −40 src/lib/queue_worker.js
  13. +73 −13 src/queue.js
  14. +11 −3 test/helpers.js
  15. BIN test/key.json.enc
  16. +120 −16 test/lib/queue_worker.spec.js
  17. +59 −0 test/queue.spec.js
103 changes: 103 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
# Contributing | Firebase Queue

Thank you for contributing to the Firebase community!

- [Have a usage question?](#question)
- [Think you found a bug?](#issue)
- [Have a feature request?](#feature)
- [Want to submit a pull request?](#submit)
- [Need to get set up locally?](#local-setup)


## <a name="question"></a>Have a usage question?

We get lots of those and we love helping you, but GitHub is not the best place for them. Issues
which just ask about usage will be closed.

Start with the [guide](../docs/guide.md). If the official documentation doesn't help, try asking a
question through our [official support channels](https://firebase.google.com/support/).

**Please avoid double posting across multiple channels!**


## <a name="issue"></a>Think you found a bug?

Yeah, we're definitely not perfect!

Search through [old issues](https://github.com/firebase/firebase-queue/issues) before submitting a new
issue as your question may have already been answered.

If your issue appears to be a bug, and hasn't been reported,
[open a new issue](https://github.com/firebase/firebase-queue/issues/new). Please use the provided bug
report template and include a minimal repro.

If you are up to the challenge, [submit a pull request](#submit) with a fix!


## <a name="feature"></a>Have a feature request?

Great, we love hearing how we can improve our products! After making sure someone hasn't already
requested the feature in the [existing issues](https://github.com/firebase/firebase-queue/issues), go
ahead and [open a new issue](https://github.com/firebase/firebase-queue/issues/new). Feel free to remove
the bug report template and instead provide an explanation of your feature request. Provide code
samples if applicable. Try to think about what it will allow you to do that you can't do today? How
will it make current workarounds straightforward? What potential bugs and edge cases does it help to
avoid?


## <a name="submit"></a>Want to submit a pull request?

Sweet, we'd love to accept your contribution! [Open a new pull request](https://github.com/firebase/firebase-queue/pull/new/master)
and fill out the provided form.

**If you want to implement a new feature, please open an issue with a proposal first so that we can
figure out if the feature makes sense and how it will work.**

Make sure your changes pass our linter and the tests all pass on your local machine. We've hooked
up this repo with continuous integration to double check those things for you.

Most non-trivial changes should include some extra test coverage. If you aren't sure how to add
tests, feel free to submit regardless and ask us for some advice.

Finally, you will need to sign our [Contributor License Agreement](https://cla.developers.google.com/about/google-individual)
before we can accept your pull request.


## <a name="local-setup"></a>Need to get set up locally?

If you'd like to contribute to Firebase Queue, you'll need to do the following to get your
environment set up.

### Install Dependencies

```bash
$ git clone https://github.com/firebase/firebase-queue.git
$ cd firebase-queue # go to the firebase-queue directory
$ npm install -g gulp # globally install gulp task runner
$ npm install # install local npm build / test dependencies
```

### Create a Firebase Project

1. Create a Firebase project [here](https://console.firebase.google.com).
2. Set the `FB_QUEUE_TEST_DB_URL` environment variable to your project's database URL:

```bash
$ export FB_QUEUE_TEST_DB_URL="https://<YOUR-DATABASE-NAME>.firebaseio.com"
```

### Download a Service Account JSON File

1. Follow the instructions [here](https://firebase.google.com/docs/server/setup#add_firebase_to_your_app)
on how to create a service account for your project and furnish a private key.
2. Copy the credentials JSON file to `test/key.json`.

### Lint, Build, and Test

```bash
$ gulp # lint, build, and test

$ gulp lint # just lint
$ gulp build # just build
$ gulp test # just test
```
56 changes: 56 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<!--
Thank you for contributing to the Firebase community!
Have a usage question?
=======================
We get lots of those and we love helping you, but GitHub is not the best place for them and they
will be closed.
Start with the guide: https://github.com/firebase/firebase-queue/blob/master/docs/guide.md
If the official documentation doesn't help, try asking through our official support channels:
https://firebase.google.com/support/
*Please avoid double posting across multiple channels!*
Think you found a bug?
=======================
Yeah, we're definitely not perfect! Please use the bug report template below and include a minimal
repro when opening the issue.
-->


### Version info

<!-- What versions of the following libraries are you using? Note that your issue may already
be fixed in the latest versions. -->

**Firebase:**

**Firebase Queue:**

**Node.js:**

**Other (e.g. operating system) (if applicable):**

### Test case

<!-- Provide a minimal, complete, and verifiable example (http://stackoverflow.com/help/mcve)
using either Plunker (http://plnkr.co/) or JSFiddle (https://jsfiddle.net/). -->


### Steps to reproduce

<!-- Provide the steps needed to reproduce the issue given the above test case. -->


### Expected behavior

<!-- What is the expected behavior? -->


### Actual behavior

<!-- What is the actual behavior? -->
31 changes: 31 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<!--
Thank you for contributing to the Firebase community! Please fill out the pull request form below
and make note of the following:
Run the linter and test suite
==============================
Make sure your changes pass our linter and the tests all pass on your local machine. We've hooked
up this repo with continuous integration to double check those things for you.
Add tests (if applicable)
==============================
Most non-trivial changes should include some extra test coverage. If you aren't sure how to add
tests, feel free to submit regardless and ask us for some advice.
Sign our CLA
==============================
Please sign our Contributor License Agreement (https://cla.developers.google.com/about/google-individual)
before sending PRs. We cannot accept code without this.
-->


### Description

<!-- Are you fixing a bug? Updating our documentation? Implementing a new feature? Make sure we
have the context around your change. Link to other relevant issues or pull requests. -->

### Code sample

<!-- Proposing an API change? Provide code samples showing how the API will be used. -->
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -5,3 +5,5 @@
dist/
coverage/
node_modules/

test/key.json
10 changes: 7 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
language: node_js
node_js:
- '0.10'
- '0.12'
- '4'
- '6'
- stable
sudo: false
env:
FB_QUEUE_TEST_DB_URL=https://fir-queue-test.firebaseio.com
install:
- npm install
script:
- npm run travis
- '[ -e test/key.json ] && npm run travis || false'
after_script:
- cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js
before_install:
- openssl aes-256-cbc -K $encrypted_a237b3635f54_key -iv $encrypted_a237b3635f54_iv
-in test/key.json.enc -out test/key.json -d
Loading