Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Benchmarking to target all frameworks #27

Closed
kenny-sellers opened this issue Jan 19, 2022 · 1 comment
Closed

Update Benchmarking to target all frameworks #27

kenny-sellers opened this issue Jan 19, 2022 · 1 comment

Comments

@kenny-sellers
Copy link
Collaborator

kenny-sellers commented Jan 19, 2022

Currently the benchmarking is only targeting .NET 5. We need to support all frameworks (.NET 4.8, .NET 5, .NET 6).

An example of multi-targeting the jobs can be found here: https://github.com/FileOnQ/Imaging.Heif/blob/main/benchmarks/tools/Thumbnail.cs

The build logic can be pulled from here: https://github.com/FileOnQ/Imaging.Heif/blob/main/.github/workflows/benchmark.yml

#8 and this can be completed together

@kenny-sellers
Copy link
Collaborator Author

Closed as this is included in a main framework issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant