diff --git a/autograder-core/src/main/java/de/firemage/autograder/core/ProblemType.java b/autograder-core/src/main/java/de/firemage/autograder/core/ProblemType.java index 64726879..178a5bfa 100644 --- a/autograder-core/src/main/java/de/firemage/autograder/core/ProblemType.java +++ b/autograder-core/src/main/java/de/firemage/autograder/core/ProblemType.java @@ -43,7 +43,7 @@ public enum ProblemType { REDUNDANT_MODIFIER_VISIBILITY_ENUM_CONSTRUCTOR, REDUNDANT_VOID_RETURN, REDUNDANT_SELF_ASSIGNMENT, - REDUNDANT_VARIABLE_BEFORE_RETURN, + REDUNDANT_VARIABLE, REDUNDANT_BOOLEAN_EQUAL, AVOID_RECOMPILING_REGEX, UNUSED_IMPORT, diff --git a/autograder-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariableBeforeReturn.java b/autograder-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariable.java similarity index 96% rename from autograder-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariableBeforeReturn.java rename to autograder-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariable.java index 24551b48..79290d70 100644 --- a/autograder-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariableBeforeReturn.java +++ b/autograder-core/src/main/java/de/firemage/autograder/core/check/complexity/RedundantVariable.java @@ -17,8 +17,8 @@ import java.util.Map; -@ExecutableCheck(reportedProblems = {ProblemType.REDUNDANT_VARIABLE_BEFORE_RETURN}) -public class RedundantVariableBeforeReturn extends IntegratedCheck { +@ExecutableCheck(reportedProblems = {ProblemType.REDUNDANT_VARIABLE}) +public class RedundantVariable extends IntegratedCheck { /** * Checks if the given statement does not influence the variable returned by the return statement. * @@ -59,7 +59,7 @@ private void checkVariableRead(CtStatement ctStatement, CtVariableRead ctVari "suggestion", ctStatement.prettyprint().replace(ctLocalVariable.getSimpleName(), ctLocalVariable.getDefaultExpression().prettyprint()) ) ), - ProblemType.REDUNDANT_VARIABLE_BEFORE_RETURN + ProblemType.REDUNDANT_VARIABLE ); } } diff --git a/autograder-core/src/test/java/de/firemage/autograder/core/check/complexity/TestRedundantVariableBeforeReturn.java b/autograder-core/src/test/java/de/firemage/autograder/core/check/complexity/TestRedundantVariable.java similarity index 98% rename from autograder-core/src/test/java/de/firemage/autograder/core/check/complexity/TestRedundantVariableBeforeReturn.java rename to autograder-core/src/test/java/de/firemage/autograder/core/check/complexity/TestRedundantVariable.java index cb98d496..b46f79a1 100644 --- a/autograder-core/src/test/java/de/firemage/autograder/core/check/complexity/TestRedundantVariableBeforeReturn.java +++ b/autograder-core/src/test/java/de/firemage/autograder/core/check/complexity/TestRedundantVariable.java @@ -15,8 +15,8 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -class TestRedundantVariableBeforeReturn extends AbstractCheckTest { - private static final List PROBLEM_TYPES = List.of(ProblemType.REDUNDANT_VARIABLE_BEFORE_RETURN); +class TestRedundantVariable extends AbstractCheckTest { + private static final List PROBLEM_TYPES = List.of(ProblemType.REDUNDANT_VARIABLE); void assertEqualsRedundant(Problem problem, String name, String suggestion) { assertEquals( diff --git a/jreleaser.yml b/jreleaser.yml index 595c52cb..4f3a84da 100644 --- a/jreleaser.yml +++ b/jreleaser.yml @@ -16,6 +16,7 @@ project: release: github: overwrite: true + checksums: false signatures: false releaseName: '{{tagName}}' changelog: diff --git a/sample_config.yaml b/sample_config.yaml index c383339b..177c27b4 100644 --- a/sample_config.yaml +++ b/sample_config.yaml @@ -20,7 +20,7 @@ - REDUNDANT_MODIFIER - REDUNDANT_VOID_RETURN - REDUNDANT_SELF_ASSIGNMENT -- REDUNDANT_VARIABLE_BEFORE_RETURN +- REDUNDANT_VARIABLE - UNUSED_IMPORT - PRIMITIVE_WRAPPER_INSTANTIATION - ASSERT