Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separated boolean parameters for vep and exomiser - HIGH PRIORITY #30

Open
LysianeBouchard opened this issue Oct 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@LysianeBouchard
Copy link
Contributor

LysianeBouchard commented Oct 1, 2024

Description of feature

A user can enable vep / exomiser via the --tools parameter. We would like to replace this option by 2 separated boolean options (ex: --with-vep --with-exomiser).

We think that it will reduce the complexity of the code, as, with the tools parameter, we need to add extra logic to parse the value. With dedicated boolean parameters, the logic to determine whether or not vep/exomiser applies is more straightforward and easier to read in the code.

Using high priority as, ideally, we would like to do it before qlin deployment since there is a breaking change in the input/output interface. Such change will be harder to do when we have a pipeline deployed in production.

@LysianeBouchard LysianeBouchard added the enhancement New feature or request label Oct 1, 2024
@LysianeBouchard LysianeBouchard changed the title Use separated boolean parameters for vep and exomiser Use separated boolean parameters for vep and exomiser - MEDIUM PRIORITY Oct 1, 2024
@LysianeBouchard LysianeBouchard changed the title Use separated boolean parameters for vep and exomiser - MEDIUM PRIORITY Use separated boolean parameters for vep and exomiser - HIGH PRIORITY Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant