Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Workspace Visible attribute #144

Closed
FelixSchladt opened this issue Jan 31, 2023 · 0 comments
Closed

Remove Workspace Visible attribute #144

FelixSchladt opened this issue Jan 31, 2023 · 0 comments
Assignees
@janschaible
Labels
help wanted Extra attention is needed Question Further information is requested

Comments

@FelixSchladt
Copy link
Owner

FelixSchladt commented Jan 31, 2023 •
edited
Loading

We currently store the information which workspace is currently active in two places. Once inside screeninfo.active_workspace and in workspace.visible this is kinda confusing and it seems like this is not updated correctly rn.

I would like to get @janschaible opinion if this should stay this way or if maybe a refcell etc makes more sense.
Does the workspace require this information anyway?

This is related to #143
@FelixSchladt FelixSchladt added help wanted Extra attention is needed Question Further information is requested labels Jan 31, 2023
@gungula gungula assigned janschaible and unassigned FelixSchladt Feb 28, 2023
@gungula gungula closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janschaible janschaible

Labels
help wanted Extra attention is needed Question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janschaible @FelixSchladt @gungula