Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL: Worldchat channel owner spam #201

Open
HelloKitty opened this issue Mar 30, 2017 · 2 comments
Open

QoL: Worldchat channel owner spam #201

HelloKitty opened this issue Mar 30, 2017 · 2 comments
Assignees

Comments

@HelloKitty
Copy link

It's annoying to see owner changes broadcasted for the world chat channel. I'd recommend treating the world chat channel like Trade or General.

So you can either set World's channelId to 0, thus making it a "constant" channel, which I think prevents ownership change broadcasts, or adding a simple exception for broadcasting owner changes in Channel.cpp's Channel::SetOwner. Would be nice.

I don't know a whole lot about channels, how and where they're defined, and how they work but those solutions seem viable.

@Tapswhenoom
Copy link
Collaborator

Seems like a fair idea, I believe there were some issues as well with people abusing ownership of /world

@Tapswhenoom Tapswhenoom self-assigned this Mar 30, 2017
@Zerixx
Copy link
Contributor

Zerixx commented Mar 30, 2017

@HelloKitty contact me on skype. mello_lost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants