Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should clarify expected handling of unused bits for float and double value encoding #17

Closed
cowtowncoder opened this issue Oct 18, 2021 · 1 comment

Comments

@cowtowncoder
Copy link
Member

As per:

FasterXML/jackson-dataformats-binary#301

it looks like Smile Java doc by Jackson (jackson-dataformats-binary) has somewhat inconsistent encoding behavior of unused bits. It would make sense to clarify expected handling, along the lines of (I think?):

  1. Contents of unused bits MUST be ignored by decoder
  2. Unused bits SHOULD be left as zeroes by encoder
@cowtowncoder
Copy link
Member Author

Updated

https://github.com/FasterXML/smile-format-specification/blob/master/smile-specification.md

but no version change (since behavior clarified, not changed).

Will need to tackle Jackson Smile codec in future -- likely for 2.14 as this may (even it should not) affect some decoders, issue:

FasterXML/jackson-dataformats-binary#300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant