Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ObjectReaderInjector/ObjectWriterInjector to use new (2.16) pluggable RecyclerPool instead of hard-coded one #176

Closed
cowtowncoder opened this issue Sep 30, 2023 · 1 comment

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Sep 30, 2023

Similar to FasterXML/jackson-dataformats-binary#399 (and others) (based on changes for FasterXML/jackson-core#1089)
we need to allow re-configuring of recyclers used for recycling ObjectReaderModifier/ObjectWriterModifier instances: mostly for new Project Loom (where ThreadLocal based approach won't work well) but also allow users to use more optimal pooling in general.

Ideally changes would go in 2.16, leaving default impl in use but allowing re-configuration.

@cowtowncoder
Copy link
Member Author

Actually, I forgot what ThreadLocal is used for here: it is not for Object recycling but for "AOP" style injection of modifiers.
Hence cannot be simply replaced -- if changes needed, need to think through using something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant