Failed copy(): IonValueMapper does not override copy()

[mr-robert]

When calling .copy() on instance of IonValueMapper, I expect to get a new IonValueMapper with the same configuration. However, instead I get this expection.

I am using 2.12 but I checked the source of the latest version on github, and I do not see this method overridden.

I think that as this class is provided by Jackson themselves, they should provide the implementation of the overridden .copy() in IonValueMapper.

[cowtowncoder]

@mr-robert You are absolutely correct: this method should be overridden by format-specific ObjectMapper subtypes. Exception is there to avoid case of caller accidentally getting an instance of super type -- but since ObjectMapper is concrete type, copy() method cannot be left as abstract. So it's not an optimal situation wrt ensuring implementation.

[mr-robert]

Thanks for this. I just ran into a similar issue, wondering if it should be fixed as well when using IonValueMapper.builder(...) methods, there is no overload in IonValueMapper, therefore the modules IonValueModule and EnumAsIonSymbolModule do not get attached if creating a mapper using IonValueMapper.builder(...) methods.

[cowtowncoder]

@mr-robert Could you file a separate issue for that, if you think it should be addressed?

Although to be honest, I am not 100% sure I follow: in 2.x, Builders simply wrap around ObjectMapper instances (like IonObjectMapper) so behavior should be similar.
IonValueModule and EnumAsIonSymbolModule do not seem to be added if construction IonObjectMapper directly either?

[mr-robert]

Created #509

[cowtowncoder]

Ahhhh... IonVALUEMapper, not IonObjectMapper (which has overrides). Thanks!