Annotation-provided Deserializers are not contextualized inside CreatorProperties

[aarondav]

On this line within BasicDeserializerFactory#constructCreatorProperty, we create a Deserializer based on an annotation:

JsonDeserializer<Object> deser = findDeserializerFromAnnotation(ctxt, param);
... // lines that do not reference "deser"
if (deser != null) {
    prop = prop.withValueDeserializer(deser);
}

(source)

findDeserializerFromAnnotation will resolve, but not contextualize, the resulting Deserializer. Subsequently, in PropertyBasedCreator#construct, we will construct a contextualized Deserializer if and only if a Deserializer is not already present:

if (!prop.hasValueDeserializer()) {
    prop = prop.withValueDeserializer(ctxt.findContextualValueDeserializer(prop.getType(), prop));
}

(source)

However, this returns false because we do have a value deserializer.

Finally, we attempt to deserialize using this PropertyBasedCreator, within BeanDeserializer#_deserializeUsingPropertyBased:

Object value = creatorProp.deserialize(jp, ctxt);

(source)

This fails, however, as our Deserializer was never contextualized.

If this is indeed a bug, I think a simple fix may be to simply contextualize the Deserializer within PropertyBasedCreator#construct if it's present. Let me know if that is a good solution; I can make a PR if desired.

[cowtowncoder]

Yes, it sounds like a bug: all serializers/deserializers should be contextualized (when used for a property, i.e. when there is a context). Thanks; I will fix this.

[cowtowncoder]

Added a call to contextualization; will be in 2.3.4 / 2.4.0. If you have a chance to verify from either, that'd be great, but I assume that problem is resolved.

[aarondav]

I have verified the fix in 2.3.4-SNAPSHOT. Thanks a bunch for the quick patch! @JsonDefaultValue is now more easily implementable for the Scala case class junkies among us... :)

What is the release schedule for 2.3.4?

[cowtowncoder]

I am hoping to get 2.4.0 first; there are some patches for 2.3.4, but it will probably take at least couple of weeks.

Thank you for verifying this!