Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(reverted) Add Iterable<T> as recognized IterationType instance (along with Iterable, Stream) #4443

Closed
cowtowncoder opened this issue Mar 22, 2024 · 1 comment
Closed

(reverted) Add Iterable<T> as recognized IterationType instance (along with Iterable, Stream) #4443

cowtowncoder opened this issue Mar 22, 2024 · 1 comment
Labels
2.18 will-not-fix Closed as either non-issue or something not planned to be worked on

Comments

@cowtowncoder
Copy link
Member

Describe your Issue

Since #3950 added new IterationType (in Jackson 2.16), 2 types are recognized:

       if (rawType == Iterator.class || rawType == Stream.class) {

But as per:

FasterXML/jackson-dataformat-xml#646

it would seem Iterable should also be recognized similarly. If so, this could be changed in 2.18.
@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 2.18 and removed to-evaluate Issue that has been received but not yet evaluated labels Mar 22, 2024
cowtowncoder added a commit that referenced this issue Apr 19, 2024
@cowtowncoder
Fix #4443: detect Iterable as IterationType
4768ca2
cowtowncoder added a commit that referenced this issue Apr 27, 2024
@cowtowncoder
Revert "Fix #4443: detect Iterable as IterationType (#4487)"
0611a67 
This reverts commit db623a8.
@cowtowncoder cowtowncoder changed the title Add Iterable<T> as recognized IterationType instance (along with Iterable, Stream) (reverted) Add Iterable<T> as recognized IterationType instance (along with Iterable, Stream) Apr 27, 2024
@cowtowncoder
Copy link
Member Author

Alas, had to revert this from 2.18 due to failure in https://github.com/FasterXML/jackson-datatypes-collections/ for HPPC ObjectArraySerializer serialization.

@cowtowncoder cowtowncoder added the will-not-fix Closed as either non-issue or something not planned to be worked on label Apr 27, 2024
cowtowncoder added a commit that referenced this issue Apr 27, 2024
@cowtowncoder
Revert "Fix #4443: detect Iterable as IterationType" (#4505)
c176809
@cowtowncoder cowtowncoder mentioned this issue Apr 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.18 will-not-fix Closed as either non-issue or something not planned to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cowtowncoder