From eff2db1e19266d1f32b90636353697e15ff154e1 Mon Sep 17 00:00:00 2001
From: Philippe Marschall <philippe.marschall@gmail.com>
Date: Sat, 23 Jul 2022 13:07:52 +0200
Subject: [PATCH] Avoid copy when parsing BigDecimal

Avoid a char[] copy when parsing a BigDecimal reducing intermediate
allocation.
---
 .../jackson/core/io/BigDecimalParser.java     | 21 ++++++++-----------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/src/main/java/com/fasterxml/jackson/core/io/BigDecimalParser.java b/src/main/java/com/fasterxml/jackson/core/io/BigDecimalParser.java
index 8fbaa77c9e..1386c8b08a 100644
--- a/src/main/java/com/fasterxml/jackson/core/io/BigDecimalParser.java
+++ b/src/main/java/com/fasterxml/jackson/core/io/BigDecimalParser.java
@@ -33,18 +33,11 @@ public static BigDecimal parse(String valueStr) {
     }
 
     public static BigDecimal parse(char[] chars, int off, int len) {
-        if (off > 0 || len != chars.length) {
-            chars = Arrays.copyOfRange(chars, off, off+len);
-        }
-        return parse(chars);
-    }
-
-    public static BigDecimal parse(char[] chars) {
-        final int len = chars.length;
         try {
             if (len < 500) {
-                return new BigDecimal(chars);
+                return new BigDecimal(chars, off, len);
             }
+            chars = Arrays.copyOfRange(chars, off, off+len);
             return new BigDecimalParser(chars).parseBigDecimal(len / 10);
         } catch (NumberFormatException e) {
             String desc = e.getMessage();
@@ -53,10 +46,10 @@ public static BigDecimal parse(char[] chars) {
                 desc = "Not a valid number representation";
             }
             String stringToReport;
-            if (chars.length <= MAX_CHARS_TO_REPORT) {
-                stringToReport = new String(chars);
+            if (len <= MAX_CHARS_TO_REPORT) {
+                stringToReport = new String(chars, off, len);
             } else {
-                stringToReport = new String(Arrays.copyOfRange(chars, 0, MAX_CHARS_TO_REPORT))
+                stringToReport = new String(Arrays.copyOfRange(chars, off, MAX_CHARS_TO_REPORT))
                     + "(truncated, full length is " + chars.length + " chars)";
             }
             throw new NumberFormatException("Value \"" + stringToReport
@@ -64,6 +57,10 @@ public static BigDecimal parse(char[] chars) {
         }
     }
 
+    public static BigDecimal parse(char[] chars) {
+        return parse(chars, 0, chars.length);
+    }
+
     private BigDecimal parseBigDecimal(final int splitLen) {
         boolean numHasSign = false;
         boolean expHasSign = false;