Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests for verifying basic functioning of RecyclerPool implementations (#1064) #1190

Closed
cowtowncoder opened this issue Jan 15, 2024 · 0 comments
Labels
2.16 Issue planned (at earliest) for 2.16

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Jan 15, 2024

(note: spun off of FasterXML/jackson-databind#4321)

One major new feature in Jackson 2.16 was addition of pluggable RecyclerPools (see #1064 f.ex).
But unfortunately their functioning was not tested beyond regression testing for the default, ThreadLocal-based legacy RecyclerPool.
Let's start by adding streaming-level testing first.

EDIT: there is actually one test -- BufferRecyclerPoolTest -- that verifies some aspects but is limited (only simple generation case, not parser), but we can do better.

@cowtowncoder cowtowncoder added the 2.16 Issue planned (at earliest) for 2.16 label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.16 Issue planned (at earliest) for 2.16
Projects
None yet
Development

No branches or pull requests

1 participant