Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI doesn't consider "Local Sign-In" when disabled for certain features #825

Closed
1 task done
Jacouille opened this issue Jun 21, 2024 · 2 comments
Closed
1 task done

Comments

@Jacouille
Copy link

Jacouille commented Jun 21, 2024

Description

Some features in the UI do not consider the "Local Sign-In" settings when it is disabled.

  • In the user list, the "Create Local User" button is shown when setting is disabled.
    • We should hide the button when the setting is disabled
  • In the user profile settings (/users/:userId/settings), the email is required. This was added in Login breaks without email set #803 but does not check the setting.
    • The email should not be required when the setting is disabled
  • The Password tab in the user profile settings (/users/:userId/settings) is shown. The password in that tab is the password for "Local users".
    • We should hide the tab when the setting is disabled

Version

1.9.2

Steps to Reproduce

  1. Go to the Jellyseerr setting page in the users tab (/settings/users)
  2. Disable the "Local Sign-In" setting and save your changes
  3. View the issues described in the description section above behave like the setting is still enabled

Screenshots

No response

Logs

No response

Platform

desktop

Device

all

Operating System

all

Browser

all

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@Fallenbagel
Copy link
Owner

  1. Whether you disable local sign in or not, every account is both. Every jellyfin user also is a local account. It's linked

  2. Email will be required. We will remove the validation so Email can be jellyfin username/email (it was supposed to be this way but accidental)

  3. Refer back to 1. Every user is still a local user (it's all interlinked) which is why we don't hide these settings

@gauthier-th
Copy link
Collaborator

Should be fixed by #900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants