Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting all seasons requests specials season even if it's hidden by settings #1239

Closed
1 task done
sanderai opened this issue Jan 10, 2025 · 1 comment
Closed
1 task done
Labels
awaiting triage This issue needs to be reviewed bug Something isn't working

Comments

@sanderai
Copy link

Description

v2.2.0 added a new option in the settings to permit requesting special episodes. If this option is not enabled, Specials season is not shown under a series or it's request modal.

But when selecting "all seasons" at the top of the request modal, it gets selected secretly in the background and added to the request, making notifications not work even if all the regular seasons become available (since specials are still missing from the request). This doesn't happen when selecting seasons one-by-one.

Version

v2.2.3

Steps to Reproduce

  1. Have Allow Special Episodes Requests setting ENABLED to first find a new unrequested series with known specials or delete data and requests for existing one
  2. Disable Allow Special Episodes Requests setting
  3. Go to the known series with specials and make a request, selecting the "all seasons" button in the request modal table heading
  4. Under Requests it's visible that the Specials season was still requested, despite being disabled in settings and not selected during requesting

Screenshots

Selecting seasons one-by-one is OK
image

But when selecting all, even the season count is bigger than actual visible seasons:
image

The request itself shows the Specials seasons, even though I couldn't see it when making the request:
image

Logs

No response

Platform

desktop

Database

SQLite (default)

Device

Any

Operating System

Any

Browser

Any

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@sanderai sanderai added awaiting triage This issue needs to be reviewed bug Something isn't working labels Jan 10, 2025
@sanderai
Copy link
Author

Ah sorry, looks like a (second) duplicate of #1208, which is already fixed in develop. Sorry for the spam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage This issue needs to be reviewed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant